add confmap provider to registry.json #5637
Open
+127
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will also plan to submit a separate PR to add the existing five confmap.providers to the registry once this change is approved. |
Can you put all of them in one PR? Makes it easier to validate things and how we are going to name those values. |
Yes, done. |
svrnm
requested changes
Nov 20, 2024
jackgopack4
changed the title
Co-authored-by: Severin Neumann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #5387, there are more components that are compatible with the OpenTelemetry Collector.
These include
confmap.Converterandconfmap.Providertypes.confmap.Converter: open-telemetry/opentelemetry-collector#11582
confmap.Provider: open-telemetry/opentelemetry-collector#4567
There are currently five confmap.Providers that are maintained in the OpenTelemetry Collector core repository and while there is only one Converter there and it is deprecated, there are vendors that make use of converters and it is possible they would choose to publish them in the registry once this is available.
As I am not super familiar with the registry and changes necessary to update the same, I may have missed file(s) that need to be changed and will happily make these changes if suggested.
Additionally, I don't feel strongly about calling them "confmap converter" vs. "converter" or provider, but it seemed slightly more descriptive. Open to feedback there as well.