✅ [outreachy] feat: no search entries found page (#5372) #5462
Conversation
There was a problem hiding this comment.
have you created that visualization yourself or is it from a 3rd party? Both is fine, but in the case that this is from a 3rd party, can you share a source, so we can verify that the license fits our project
There was a problem hiding this comment.
I used a 3rd party- icons 8 illustration. Here is their licence page.
If it's not possible to use this illustration, I can gladly do the changes with another illustration that fits the project.
There was a problem hiding this comment.
that link leads me to a slack space I am not in, can you send me a link that doesn't need authentication?
There was a problem hiding this comment.
Oh sorry about that, this is the link
There was a problem hiding this comment.
that license is not compatible with our project, we would need something that's licensed with a creative common or proper open source license.
Let's do the following:
- from the perspective of what I asked you to do for the outreachy application phase, this is what I was looking for, so I will mark this as "done" for you.
- from the perspective of merging this PR and making it an official part of the website, we need something different. My preferred solution is something created specifically for our project. If you have the skills for that and create such a visualization, that would be awesome. Otherwise we can look for something we can use under such a compatible license.
There was a problem hiding this comment.
@svrnm I have made the requested change. I have changed the illustration to one which is licensed under MIT license
svrnm
changed the title
|
@svrnm Thank you very much for the feedback. |
svrnm
changed the title
Closes #5372
This PR creates a new and better search result page when the is no seach found.
Steps to view work