Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pt] Add translations for /pt/docs/concepts/signals #5120

Merged
merged 30 commits into from
Sep 8, 2024
Merged

[pt] Add translations for /pt/docs/concepts/signals #5120

merged 30 commits into from
Sep 8, 2024

Conversation

vitorvasc
Copy link
Contributor

Add:

  • _index.md
  • metrics.md

Issue: #4922

@vitorvasc vitorvasc requested a review from a team August 29, 2024 11:15
@opentelemetrybot opentelemetrybot requested review from a team August 29, 2024 11:15
@vitorvasc vitorvasc mentioned this pull request Aug 29, 2024
Open
26 tasks
@vitorvasc @emdneto
Fix typo on metrics.md
9d27cbc 
Co-authored-by: Emídio Neto <[email protected]>
@opentelemetrybot opentelemetrybot requested a review from a team August 29, 2024 13:53
@opentelemetrybot opentelemetrybot requested a review from a team August 29, 2024 14:50
@opentelemetrybot opentelemetrybot requested a review from a team August 30, 2024 12:10
@edsoncelio edsoncelio mentioned this pull request Sep 4, 2024
Closed
@cassioliveiram
Copy link

Hey @vitorvasc, as mine one (#5144) is duplicated from your I'll close mine. In the meantime I've opened @theletterf has input great comments there, can you please double check and apply if it's the case?

@vitorvasc
Copy link
Contributor Author

Hey @vitorvasc, as mine one (#5144) is duplicated from your I'll close mine. In the meantime I've opened @theletterf has input great comments there, can you please double check and apply if it's the case?

Absolutely! Brought the updates as they were suggsted on the comments.

CC @theletterf, would you mind review here aswell?

Thanks!

edsoncelio
edsoncelio reviewed Sep 5, 2024
View reviewed changes
content/pt/docs/concepts/signals/_index.md Outdated
title: Sinais
description:
Aprenda sobre as categorias de telemetria suportadas pelo OpenTelemetry
aliases:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pode remover esse campo de aliases @vitorvasc, não está sendo usado, depois disso é LGTM por mim!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feito! 👌🏼

@edsoncelio
Copy link
Member

LGTM!!

@theletterf
Copy link
Member

@open-telemetry/docs-pt-approvers Remember to approve the PR if you're OK with the content. Comments don't suffice.

@edsoncelio
Copy link
Member

edsoncelio commented Sep 5, 2024 •
edited
Loading

@open-telemetry/docs-pt-approvers Remember to approve the PR if you're OK with the content. Comments don't suffice.

Hi @theletterf, if this is related to my comment above - I'm not part of the OTel org yet; I'm commenting with LGTM just because I helped to review :)

But thanks for the reminder!!

@edsoncelio edsoncelio mentioned this pull request Sep 5, 2024
Closed
6 tasks
@EzzioMoreira
Copy link
Contributor

Parabéns @vitorvasc
LGTM!!!!!

EzzioMoreira
EzzioMoreira approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@EzzioMoreira EzzioMoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theletterf theletterf added this pull request to the merge queue Sep 8, 2024
Merged via the queue into open-telemetry:main with commit a8e0c2e Sep 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzzioMoreira EzzioMoreira EzzioMoreira approved these changes

@theletterf theletterf theletterf approved these changes

@emdneto emdneto Awaiting requested review from emdneto

@edsoncelio edsoncelio Awaiting requested review from edsoncelio

Assignees
No one assigned
Labels
lang:pt
Projects
SIG Comms: Docs Translation
Status: Done
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vitorvasc @cassioliveiram @edsoncelio @theletterf @EzzioMoreira @emdneto