Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a way to generate XCFramework that can be used for releases #528

Closed

Conversation

tapthaker
Copy link

I am not aware of all the packages that should be generated for releases. We needed OpenTelemetryApi, but it should be easy to extend it for other packages.

Copy link

linux-foundation-easycla bot commented Apr 1, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tapthaker / name: Tapan Thaker (683b387)

@heckj
Copy link

heckj commented Apr 1, 2024

Just a head's up - if you want to use an XCFramework in an app deliverable through the App Store, Apple will require that it is both signed and includes a privacy manifest.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.45%. Comparing base (34c4569) to head (683b387).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
+ Coverage   68.41%   68.45%   +0.03%     
==========================================
  Files         344      344              
  Lines       15151    15151              
==========================================
+ Hits        10365    10371       +6     
+ Misses       4786     4780       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@nachoBonafonte
Copy link
Member

We think it is a great start, but to be really useful for the project we would need it to allow selecting which targets of the project to include and also to be able to select the platforms/destinations to build for. Then it would be a great tool for any user. With the functionality as is the audience for this change is too narrow. Would you mind expanding it?

@nachoBonafonte
Copy link
Member

Hi @tapthaker, are you interested in improving the PR with the needs exposed?

@tapthaker
Copy link
Author

I missed your previous comment. Yes I am interested in modifying this PR. I'll get back to you

@n-ravichandran
Copy link

@tapthaker Does this approach work for packages with external dependencies or resources, like the exporters that depend on swift-protofbuf and swift-nio?

@bryce-b
Copy link
Member

bryce-b commented Nov 21, 2024

I'm going to close this, as it's pretty stale. If the requested changes are made in the future, please reopen!

@bryce-b bryce-b closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants