-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a way to generate XCFramework that can be used for releases #528
Conversation
|
d8a47f0
to
683b387
Compare
Just a head's up - if you want to use an XCFramework in an app deliverable through the App Store, Apple will require that it is both signed and includes a privacy manifest. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
+ Coverage 68.41% 68.45% +0.03%
==========================================
Files 344 344
Lines 15151 15151
==========================================
+ Hits 10365 10371 +6
+ Misses 4786 4780 -6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
We think it is a great start, but to be really useful for the project we would need it to allow selecting which targets of the project to include and also to be able to select the platforms/destinations to build for. Then it would be a great tool for any user. With the functionality as is the audience for this change is too narrow. Would you mind expanding it? |
Hi @tapthaker, are you interested in improving the PR with the needs exposed? |
I missed your previous comment. Yes I am interested in modifying this PR. I'll get back to you |
@tapthaker Does this approach work for packages with external dependencies or resources, like the exporters that depend on |
I'm going to close this, as it's pretty stale. If the requested changes are made in the future, please reopen! |
I am not aware of all the packages that should be generated for releases. We needed
OpenTelemetryApi
, but it should be easy to extend it for other packages.