Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTLP integration test for hyper and request client for logs and traces #2312

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Nov 20, 2024

Changes

reqwest-blocking is failing, could be the issue with the exporter. will fix that separately.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner November 20, 2024 20:08
@lalitb lalitb added the integration tests Run integration tests label Nov 20, 2024
@lalitb
Copy link
Member Author

lalitb commented Nov 20, 2024

Moving to draft to fix build issues

@lalitb lalitb marked this pull request as draft November 20, 2024 20:27
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.5%. Comparing base (ca6c67e) to head (968b0e8).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2312   +/-   ##
=====================================
  Coverage   79.5%   79.5%           
=====================================
  Files        123     123           
  Lines      21282   21282           
=====================================
+ Hits       16925   16927    +2     
+ Misses      4357    4355    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lalitb
Copy link
Member Author

lalitb commented Nov 20, 2024

Moving to draft to fix build issues

ok fixed the build now.

@lalitb lalitb marked this pull request as ready for review November 20, 2024 21:25
@lalitb lalitb changed the title Add OTLP integration test for hyper and request client for logs and metrics Add OTLP integration test for hyper and request client for logs and traces Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests Run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant