feat: update otel versions for prometheus to 0.27 #2309
Conversation
kudlatyamroth
force-pushed
the
feature/update-prometheus-to-otel-27
branch
from
4800dd6 to
eda6bca
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2309 +/- ##
=====================================
Coverage 79.4% 79.4%
=====================================
Files 123 123
Lines 21484 21488 +4
=====================================
+ Hits 17064 17068 +4
Misses 4420 4420 ☔ View full report in Codecov by Sentry. |
kudlatyamroth
force-pushed
the
feature/update-prometheus-to-otel-27
branch
from
eda6bca to
13ca8df
Compare
kudlatyamroth
force-pushed
the
feature/update-prometheus-to-otel-27
branch
from
13ca8df to
984b0d8
Compare
There was a problem hiding this comment.
Changes look good. I am requesting changes to fix the internal logs. These are now emitted via tracing and most users likely have a tracing subscriber already enabled.. So we need to be very careful about emitting logs, especially the ones with high severity.
Also, try and make the descriptions more self-explanatory.(Totally understand these are existing issues, but just want to make it easier for end users to navigate the internal logs)
Enhanced error messages with specific names and differentiated warnings. Updated temporality method for Prometheus to always return cumulative temporality, aligning with Prometheus behavior.
Updated several error log names in `opentelemetry-prometheus/src/lib.rs` for better clarity and consistency. This includes renaming `AcquireLockError`, `ReaderError`, and `MetricValidation` to `MetricScrapeFailed` and `MetricValidationFailed`.
This commit introduces predefined boundary constants for histograms and applies them in several test cases within the Prometheus exporter integration test. It eliminates the use of the experimental metrics view feature by removing its configuration from the SdkMeterProvider setup and the dependencies. Change taken from @ttys3, thanks :) Co-authored-by: ttys3 <[email protected]>
|
Hi, is there a published opentelemetry-prometheus crate that one can depend on with this change? |
|
i was hoping that merge will be followed by release... but it looks like we will need to wait |
|
the crate was released last week, sorry missed to update here! |
Changes
opentelemetrydependency version to 0.27opentelemetry_sdkdependency version to 0.27opentelemetry-semantic-conventionsdependency version to 0.27Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes