DRAFT: metrics sharding handwritten #2304
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed in our meeting, I'm creating a draft version with implemented sharding:
It mainly consist of these steps:
collect_and_reset
rustc-hash
as hashing function (seam to be faster thenahash
crate, on my machine)dashmap
.Could probably be using
dashmap
directly as well, but it's quite trivial to write it our own, and we can avoid having extra dependency :)Waiting for your test results :)
Would be good to know CPU and rust version.