Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: random order for promethus #2224

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ouertani
Copy link
Contributor

Fixes #
Design discussion issue (if applicable) #

I'm facing random tests for Prometheus sanitization: #2183

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • [ x] CONTRIBUTING guidelines followed
  • [x ] Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@ouertani ouertani requested a review from a team as a code owner October 21, 2024 17:57
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.1%. Comparing base (ea4b5e4) to head (f4ec413).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2224     +/-   ##
=======================================
- Coverage   79.1%   79.1%   -0.1%     
=======================================
  Files        121     121             
  Lines      21082   21081      -1     
=======================================
- Hits       16680   16679      -1     
  Misses      4402    4402             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some pending PRs on how to address this like #2093

Will be better off to wait for them to get in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants