Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update que Appraisals #1256

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kaylareopelle
Copy link
Contributor

The latest version of the gem now supports Rails 7.2

Resolves: #1110

Comment on lines +14 to +18
if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.1.0')
gem 'activerecord', '~> 7.2.0'
else
gem 'activerecord'
end
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, we'd skip testing on Rails 7.2 and jump straight to Rails 8.0. Que made a change to support Rails 7.2 in 2.4.1, but our instrumentation didn't need to change.

Since these tests are for our instrumentation and not necessarily for activerecord compatibility with que, I'm not sure we need the condition. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

que test suite failures
1 participant