-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Set minimum supported version to Ruby 3.1 #1216
Draft
arielvalentin
wants to merge
5
commits into
open-telemetry:main
Choose a base branch
from
arielvalentin:drop-ruby-3.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+68
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.0 is no longer receiving security updates. Per our manitenace policy we will only provide updates for Ruby and library versions that are at a minimum receiving security updates. Any users that require Ruby support prior to 3.0 should pin their versions > Ruby 3.0 > status: eol > release date: 2020-12-25 > normal maintenance until: 2023-04-01 > EOL: 2024-04-23 cc: open-telemetry#1211
arielvalentin
requested review from
robbkidd,
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
ahayworth,
plantfansam,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
October 25, 2024 15:02
simi
approved these changes
Oct 25, 2024
kaylareopelle
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
scbjans
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the following gemspecs are missing, and should be updated as well
instrumentation/gruf/opentelemetry-instrumentation-gruf.gemspec
resources/azure/opentelemetry-resource-detector-azure.gemspec
resources/container/opentelemetry-resource-detector-container.gemspec
resources/google_cloud_platform/opentelemetry-resource-detector-google_cloud_platform.gemspec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.0 is no longer receiving security updates.
Per our manitenace policy we will only provide updates for Ruby and library versions that are at a minimum receiving security updates.
Any users that require Ruby support prior to 3.0 should pin their versions
cc: #1211