feat: add sem_conv opt in #1166
Draft
+78
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instrumentation/http/test/instrumentation/http/patches/client_test.rb
Outdated
Show resolved
Hide resolved
instrumentation/http/lib/opentelemetry/instrumentation/http/patches/client.rb
Show resolved
Hide resolved
| @@ -182,5 +186,45 @@ | |||
| ) | |||
| end | |||
| end | |||
|
|
|||
| describe 'Semantic conventions http stability' do | |||
There was a problem hiding this comment.
I get that we're blocked to run the tests on the CI right now without a lot of temporary code since this relies on work that is not yet part of the semantic conventions gem.
Do you have anything that demonstrates the tests passing that we could use for now? Maybe a minitest screenshot?
There was a problem hiding this comment.
Mini screenshoot ◡̈ :
Co-authored-by: Kayla Reopelle <[email protected]>
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
kaylareopelle
added
keep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by open-telemetry/opentelemetry-ruby#1728
Brings in
OpenTelemetry::SemanticConventions::StabilityModefor HTTP attributes. HTTP instrumentation should set the attribute name based on which semantic version a user sets using the environment variableOTEL_SEMCONV_STABILITY_OPT_IN(spec). That information is read byOpenTelemetry::SemanticConventions::StabilityModeto determine which attribute to send.