Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

que test suite failures #1110

Open
arielvalentin opened this issue Aug 11, 2024 · 6 comments · May be fixed by #1256
Open

que test suite failures #1110

arielvalentin opened this issue Aug 11, 2024 · 6 comments · May be fixed by #1256

Comments

@arielvalentin
Copy link
Collaborator

The nightly build for queue started failing with what seems to be incompatibilities with newer versions of Rails.

cc: @indrekj as the current maintainer of the que instrumentation.

1) Error:
  OpenTelemetry::Instrumentation::Que::span propagation::when propagation_style is set to link#test_0003_links spans together:
  NoMethodError: undefined method `clear_active_connections!' for class ActiveRecord::Base
      /opt/hostedtoolcache/Ruby/3.3.4/x64/lib/ruby/gems/3.3.0/gems/activerecord-7.2.0/lib/active_record/dynamic_matchers.rb:22:in `method_missing'
      /opt/hostedtoolcache/Ruby/3.3.4/x64/lib/ruby/gems/3.3.0/gems/que-1.4.0/lib/que/active_record/connection.rb:45:in `call'
      /opt/hostedtoolcache/Ruby/3.3.4/x64/lib/ruby/gems/3.3.0/gems/que-1.4.0/lib/que/utils/middleware.rb:36:in `invoke_middleware'
      (eval at /opt/hostedtoolcache/Ruby/3.3.4/x64/lib/ruby/gems/3.3.0/gems/que-1.4.0/lib/que/utils/middleware.rb:14):11:in `run_job_middleware'
      test/opentelemetry/instrumentation/que_test.rb:[170](https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/10335505991/job/28610140236#step:4:181):in `block (4 levels) in <top (required)>'

https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/10335505991/job/28610140236
@kaylareopelle
Copy link
Contributor

This is temporarily fixed by #1112, by preventing the tests from running on 7.2.

que-rb/que#423 at commit dcdbe94 will get the tests to pass with Rails 7.2. However, it's still in review. Further discussion in que-rb/que#425.

@github-actions GitHub Actions
Copy link
Contributor

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale Marks an issue/PR stale label Sep 14, 2024
@kaylareopelle kaylareopelle removed the stale Marks an issue/PR stale label Sep 16, 2024
@kaylareopelle
Copy link
Contributor

Reached back out on que-rb/que#425 to check the status.

@github-actions GitHub Actions
Copy link
Contributor

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale Marks an issue/PR stale label Oct 17, 2024
@kaylareopelle kaylareopelle removed the stale Marks an issue/PR stale label Oct 17, 2024
@kaylareopelle
Copy link
Contributor

The PR to support Rails 7.2 hasn't been merged yet. I'll use the stalebot's cycle to remind me to check the status.

@github-actions GitHub Actions
Copy link
Contributor

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale Marks an issue/PR stale label Nov 17, 2024
@kaylareopelle kaylareopelle removed the stale Marks an issue/PR stale label Nov 18, 2024
@kaylareopelle kaylareopelle linked a pull request Nov 19, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Update que Appraisals kaylareopelle/opentelemetry-ruby-contrib
2 participants
@arielvalentin @kaylareopelle