infra: remove generate contrib workflows from core #4302
+13
−2,427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
emdneto
changed the title
emdneto
commented
Nov 21, 2024
|
|
||
| jobs: | ||
| contrib_0: | ||
| uses: emdneto/opentelemetry-python-contrib/.github/workflows/core_contrib_test_0.yml@generate-workflows-core |
There was a problem hiding this comment.
Note: change this after reviews if approved. We need to merge open-telemetry/opentelemetry-python-contrib#3035 first. Please do not resolve this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically shifts from depending on generating workflows every time we change something in contrib to looking to contrib@main and reusing the workflow core_contrib_test.yml. With that, we only need to update contrib workflows, and there's no need to sync workflows in core anymore.
Related PR in contrib: open-telemetry/opentelemetry-python-contrib#3035
Part of #4263