Rename line -> lines and sample -> samples since these are repeated fields #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalexand
changed the title
|
@open-telemetry/profiling-approvers |
bogdandrutu
approved these changes
Sep 4, 2025
florianl
approved these changes
Sep 5, 2025
christos68k
approved these changes
Sep 5, 2025
jhalliday
approved these changes
Sep 5, 2025
pellared
approved these changes
Sep 5, 2025
reyang
approved these changes
Sep 5, 2025
|
@aalexand would you update the changelog? Thanks! |
…ields. Protobuf [docs](https://protobuf.dev/programming-guides/style/#field-names) say: > Use pluralized names for repeated fields. Other fields in profiles.proto and other OTLP types follow that recommended style AFAICT. The only fields that do not are `line` and `sample`, and I think those are remnants of the now-gone exact pprof format compatibility we explored early on. As we approach the Alpha release of the profiles signal, let's be consistent in how we name repeated fields and use plural here.
Done. |
reyang
reviewed
Sep 5, 2025
| ## Unreleased | ||
|
|
||
| The full list of changes can be found in the compare view for the respective release at <https://github.com/open-telemetry/opentelemetry-proto/releases>. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ields.
Protobuf
docs say:
Other fields in profiles.proto and other OTLP types follow that recommended style AFAICT. The only fields that do not are
lineandsample, and I think those are remnants of the now-gone exact pprof format compatibility we explored early on.As we approach the Alpha release of the profiles signal, let's be consistent in how we name repeated fields and use plural here.