[WIP] Add AWS Cloud Map support for collector discovery #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd fix collector routine blocking on AWSCloudMap Watch function
|
ls-spryker
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Based on #3317 , the Target Allocator becomes a center piece for scaling prometheus receiver based configurations of Gateway Collector.
This PR aims to introduce AWS Cloud Map based collector discovery so the TA can run in ECS and automatically discover and distribute prometheus configuration.
This PR does not aim to introduce service discovery for AWS Cloud Map. Currently this is achieved by running a side car collector to the TA task with ECS/Observers for the purpose.
Link to tracking Issue(s): 3317
Testing: Manual testing was done in AWS ECS cluster with a awsvpc based networking Service and 2 gateway collectors which uses HTTP-based service discovery.
Documentation: