Allow disabling the creation of the SM for operator metrics #3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iblancasa
commented
Dec 3, 2024
iblancasa
commented
- Resolves: operator doesn't respect manager.serviceMonitor.enabled helm value #3474
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
swiatekm
approved these changes
Dec 3, 2024
jaronoff97
approved these changes
Dec 3, 2024
|
We should label this as a breaking change, but imo disabled is the better default. Most of the time, packaging (usually Helm or kustomize) is going to take care of this. The intended use case here is primarily OpenShift in my view. |
Signed-off-by: Israel Blancas <[email protected]>
|
Done @swiatekm |
swiatekm
approved these changes
Dec 4, 2024
| component: operator | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Make ServiceMonitor for operator metrics optional |
There was a problem hiding this comment.
Suggested change
| note: Make ServiceMonitor for operator metrics optional | |
| note: Make ServiceMonitor for operator metrics optional and disable it by default |
Comment on lines
+17
to
+18
| Add create-sm-operator-metrics flag to create a ServiceMonitor for the operator metrics. | ||
| This is disabled by default to avoid breaking changes. |
There was a problem hiding this comment.
Suggested change
| Add create-sm-operator-metrics flag to create a ServiceMonitor for the operator metrics. | |
| This is disabled by default to avoid breaking changes. | |
| Add `--create-sm-operator-metrics` flag to create a ServiceMonitor for the operator metrics. | |
| This is disabled by default, which is a breaking change, because it was enabled by default in 0.113.0 and 0.114.0. |
frzifus
reviewed
Dec 5, 2024
| @@ -424,7 +427,7 @@ func main() { | |||
| os.Exit(1) | |||
| } | |||
|
|
|||
| if cfg.PrometheusCRAvailability() == prometheus.Available { | |||
| if cfg.PrometheusCRAvailability() == prometheus.Available && createSMOperatorMetrics { | |||
There was a problem hiding this comment.
Can we add a comment here? Maybe just linking the pr?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.