Create service for extensions

[Ankit152]

Description:

The Otel Operator doesn't creates a service for extensions. This will help the operator to create Service for extensions which will be consumed by an Ingress so that users can interact with it directly. This is related to deployment of Jaeger V2 in k8s.

Link to tracking Issue(s):

• Kubernetes Operator to support Jaeger-v2  jaegertracing/jaeger-operator#2717
• [Collector] Create a service for extensions which can be exposed to a port #3460

Testing:

Documentation:

[pavolloffay]

great progress,

Please add unit tests and e2e test

[swiatekm]

This looks good to me overall, left a few comments and questions.

[swiatekm]

I wanted to be clearer about how I'd like the e2e test you added to look like. I'm including some suggestions to help demonstrate that. Fundamentally, the manifests we assert against should only contain attributes that are relevant to this specific test.

The rest of this PR looks good to me, nicely done. 👍

[swiatekm]

Suggested change

	apiVersion: v1
	kind: ServiceAccount
	metadata:
	labels:
	app.kubernetes.io/component: opentelemetry-collector
	app.kubernetes.io/managed-by: opentelemetry-operator
	app.kubernetes.io/name: jaeger-inmemory-collector
	app.kubernetes.io/part-of: opentelemetry
	app.kubernetes.io/version: latest
	name: jaeger-inmemory-collector
	ownerReferences:
	- apiVersion: opentelemetry.io/v1beta1
	blockOwnerDeletion: true
	controller: true
	kind: OpenTelemetryCollector
	name: jaeger-inmemory
	---

[swiatekm]

Suggested change

	metadata:
	labels:
	app.kubernetes.io/component: opentelemetry-collector
	app.kubernetes.io/managed-by: opentelemetry-operator
	app.kubernetes.io/name: jaeger-inmemory-collector
	app.kubernetes.io/part-of: opentelemetry
	app.kubernetes.io/version: latest
	operator.opentelemetry.io/collector-service-type: base

[swiatekm]

Suggested change

	ownerReferences:
	- apiVersion: opentelemetry.io/v1beta1
	blockOwnerDeletion: true
	controller: true
	kind: OpenTelemetryCollector
	name: jaeger-inmemory

[swiatekm]

Suggested change

	internalTrafficPolicy: Cluster
	ipFamilies:
	- IPv4
	ipFamilyPolicy: SingleStack

[swiatekm]

Suggested change

	selector:
	app.kubernetes.io/component: opentelemetry-collector
	app.kubernetes.io/managed-by: opentelemetry-operator
	app.kubernetes.io/part-of: opentelemetry
	sessionAffinity: None
	type: ClusterIP
	status:
	loadBalancer: {}

[swiatekm]

Suggested change

	metadata:
	annotations:
	deployment.kubernetes.io/revision: "1"
	generation: 1
	labels:
	app.kubernetes.io/component: opentelemetry-collector
	app.kubernetes.io/managed-by: opentelemetry-operator
	app.kubernetes.io/name: jaeger-inmemory-collector
	app.kubernetes.io/part-of: opentelemetry
	app.kubernetes.io/version: latest

[swiatekm]

Suggested change

	ownerReferences:
	- apiVersion: opentelemetry.io/v1beta1
	blockOwnerDeletion: true
	controller: true
	kind: OpenTelemetryCollector
	name: jaeger-inmemory

[swiatekm]

Suggested change

	replicas: 1
	selector:
	matchLabels:
	app.kubernetes.io/component: opentelemetry-collector
	app.kubernetes.io/managed-by: opentelemetry-operator
	app.kubernetes.io/part-of: opentelemetry
	strategy:
	rollingUpdate:
	maxSurge: 25%
	maxUnavailable: 25%
	type: RollingUpdate
	template:
	metadata:
	annotations:
	prometheus.io/path: /metrics
	prometheus.io/port: "8888"
	prometheus.io/scrape: "true"
	creationTimestamp: null
	labels:
	app.kubernetes.io/component: opentelemetry-collector
	app.kubernetes.io/managed-by: opentelemetry-operator
	app.kubernetes.io/name: jaeger-inmemory-collector
	app.kubernetes.io/part-of: opentelemetry
	app.kubernetes.io/version: latest

[swiatekm]

Suggested change

	- args:
	- --config=/conf/collector.yaml
	env:
	- name: POD_NAME
	valueFrom:
	fieldRef:
	apiVersion: v1
	fieldPath: metadata.name
	image: jaegertracing/jaeger-snapshot:latest
	imagePullPolicy: Always
	name: otc-container

[swiatekm]

Suggested change

	resources: {}
	terminationMessagePath: /dev/termination-log
	terminationMessagePolicy: File
	volumeMounts:
	- mountPath: /conf
	name: otc-internal
	dnsConfig: {}
	dnsPolicy: ClusterFirst
	restartPolicy: Always
	schedulerName: default-scheduler
	securityContext: {}
	serviceAccount: jaeger-inmemory-collector
	serviceAccountName: jaeger-inmemory-collector
	shareProcessNamespace: false
	terminationGracePeriodSeconds: 30