Add support for persistentVolumeClaimRetentionPolicy field #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
reviewed
Oct 14, 2024
…difficulty and low added value
…y-operator into 3305-persistentVolumeClaimRetentionPolicy
swiatekm
approved these changes
Oct 15, 2024
jaronoff97
approved these changes
Oct 15, 2024
Co-authored-by: Jacob Aronoff <[email protected]>
|
@davidhaja you need to regenerate documentation, your typo fix to the comment isn't reflected there. |
iblancasa
approved these changes
Oct 21, 2024
|
I'm going to merge this after #3351, to avoid having to regenerate the changelog for 0.111.0. |
jaronoff97
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support for
persistentVolumeClaimRetentionPolicyfield in opentelemetrycollector CR.The
persistentVolumeClaimRetentionPolicyworks only instatefulsetmode.persistentVolumeClaimRetentionPolicydescribes the lifecycle of persistent volume claims created fromvolumeClaimTemplates.Link to tracking Issue(s):
3305
Testing:
tests/e2e/statefulset-featurese2e test updated with the new field.Unit tests created for the conversion between api versions, statefulset mode check and for the correct propagation of the
persistentVolumeClaimRetentionPolicyfield.Documentation:
docs/api.mdupdated with the new field.