apis/v1alpha1: initialize sampler CR #3280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzifus
commented
Sep 11, 2024
apis/v1alpha1/sampler_types.go
Outdated
|
|
||
| // SamplerStatus defines the observed state of Sampler | ||
| type SamplerStatus struct { | ||
| // TODO(@frzifus): add status fields |
There was a problem hiding this comment.
I will fill this when I start working on the reconciler.
| // Sampler defines sampling configuration. | ||
| type Sampler struct { | ||
| // SamplerConfig defines sampling configuration. | ||
| type SamplerConfig struct { |
There was a problem hiding this comment.
The data structure got renamed to avoid a conflict with the Sampler CR.
Signed-off-by: Benedikt Bongartz <[email protected]>
frzifus
force-pushed
the
sampling
branch
3 times, most recently
from
f6819fa
to
c7cb7fa
Compare
Signed-off-by: Benedikt Bongartz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR only contains the CR boilerplate. At this point its not included in the Operator CSV.
Link to tracking Issue(s):
Testing:
Documentation: