-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(resources): update semconv usage to modern ATTR_ export names #5187
base: main
Are you sure you want to change the base?
chore(resources): update semconv usage to modern ATTR_ export names #5187
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5187 +/- ##
==========================================
+ Coverage 94.58% 94.59% +0.01%
==========================================
Files 314 315 +1
Lines 7993 8008 +15
Branches 1611 1611
==========================================
+ Hits 7560 7575 +15
Misses 433 433
|
ATTR_CLOUD_REGION, | ||
ATTR_CONTAINER_ID, | ||
ATTR_CONTAINER_IMAGE_NAME, | ||
ATTR_CONTAINER_IMAGE_TAGS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer note: A slightly subtle change is that this changed from container.image.tag
(singular) to container.image.tags
(plural). That was changed in semconv 1.22 (changelog entry), but isn't mentioned in the schema.yaml files.
Note as well that testing for container.image.*
is a little weird, because those resource attributes are only used in tests (in this package, in the "sdk-node" package, and in the "test-utils" package in the contrib repo). I think the assertContainerResource()
function was written 4+ years ago and then copy-pasta'd to the other two packages' tests.
Note that the 'incubating' entry-point is still used in tests, which might be a nice way to watch for and catch breaking changes without breaking runtime code.
Refs: #4896
status
This is in draft while we discuss how to handle using unstable semconv attributes: (1) use the incubating entry-point or (2) make local copies of the unstable constants. See #5182 (comment)