Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: update typescript to version 5.6.3 #5145

Open
wants to merge 14 commits into
base: next
Choose a base branch
from

Conversation

david-luna
Copy link
Contributor

@david-luna david-luna commented Nov 12, 2024

Closes: #4870

Checklist:

  • Update typescript to 5.6.3
  • Document our new minimum typescript version
    • Document a policy for updating typescript in minor versions in the future
  • Add a test project to ensure that minimum typescript version can compile using the updated otel dependencies

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (4a394cc) to head (703f0ab).
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #5145      +/-   ##
==========================================
- Coverage   93.15%   93.15%   -0.01%     
==========================================
  Files         315      315              
  Lines        8113     8111       -2     
  Branches     1633     1632       -1     
==========================================
- Hits         7558     7556       -2     
  Misses        555      555              
Files with missing lines Coverage Δ
...es/opentelemetry-instrumentation-grpc/src/utils.ts 84.61% <ø> (ø)

... and 6 files with indirect coverage changes

---- 🚨 Try these New Features:

@david-luna
Copy link
Contributor Author

I starting to think that maybe we need a next branch in the contrib repository so we can sync this type of changes 🤔

@david-luna
Copy link
Contributor Author

  • Add a test project to ensure that minimum typescript version can compile using the updated otel dependencies

@pichlermarc @dyladan
I see a project name esm-http-ts within examples folder. Could that be our testing project? or it's preferable to have something more complex within integration-tests maybe?

@david-luna david-luna marked this pull request as ready for review November 18, 2024 15:50
@david-luna david-luna requested a review from a team as a code owner November 18, 2024 15:50
@@ -129,39 +129,3 @@ jobs:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
with:
verbose: true
api-eol-node-test:
Copy link
Contributor Author

@david-luna david-luna Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note for reviewer: TypeScript 5.0+ removes support for Node.js <=12.0

@@ -1 +1 @@
require: 'ts-node/register'
require: 'ts-node/register/transpile-only'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note for reviewer: extracted from https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2481/files#r1807185358. Type checking is done in compilation process so it's okay to skip here.

TypeScript version used to compile the pacakges is `v5.6.3`. If you plan to make your own instrumentation script
in a `.ts` file it is recommended to use same version or higher.

<!-- TODO: review the update policy -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note for reviewer: any other items we can add to this list?

@david-luna david-luna changed the title chore: update typescript chore!: update typescript to version 5.6.3 Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant