-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: update typescript to version 5.6.3
#5145
base: next
Are you sure you want to change the base?
chore!: update typescript to version 5.6.3
#5145
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #5145 +/- ##
==========================================
- Coverage 93.15% 93.15% -0.01%
==========================================
Files 315 315
Lines 8113 8111 -2
Branches 1633 1632 -1
==========================================
- Hits 7558 7556 -2
Misses 555 555
|
I starting to think that maybe we need a |
@pichlermarc @dyladan |
@@ -129,39 +129,3 @@ jobs: | |||
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} | |||
with: | |||
verbose: true | |||
api-eol-node-test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for reviewer: TypeScript 5.0+ removes support for Node.js <=12.0
@@ -1 +1 @@ | |||
require: 'ts-node/register' | |||
require: 'ts-node/register/transpile-only' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for reviewer: extracted from https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2481/files#r1807185358. Type checking is done in compilation process so it's okay to skip here.
TypeScript version used to compile the pacakges is `v5.6.3`. If you plan to make your own instrumentation script | ||
in a `.ts` file it is recommended to use same version or higher. | ||
|
||
<!-- TODO: review the update policy --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for reviewer: any other items we can add to this list?
5.6.3
Closes: #4870
Checklist: