Logs API: Add emitEvent to Logs API #5050
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5050 +/- ##
==========================================
+ Coverage 93.26% 93.27% +0.01%
==========================================
Files 317 317
Lines 8195 8209 +14
Branches 1641 1646 +5
==========================================
+ Hits 7643 7657 +14
Misses 552 552
|
obecny
reviewed
Oct 23, 2024
|
|
||
| public emitEvent(eventRecord: logsAPI.EventRecord): void { | ||
| const attributes = eventRecord.attributes || {}; | ||
| attributes['event.name'] = eventRecord.name; |
There was a problem hiding this comment.
Nit: (use semantic conventions)
Suggested change
| attributes['event.name'] = eventRecord.name; | |
| attributes[ATTR_EVENT_NAME] = eventRecord.name; |
Karlie-777
commented
Nov 5, 2024
|
|
||
| type Get<T> = (version: number) => T; | ||
| type OtelGlobal = Partial<{ | ||
| [GLOBAL_LOGS_API_KEY]: Get<LoggerProvider>; | ||
| [GLOBAL_EXPERIMENTAL_LOGS_API_KEY]: Get<ExperimentalLoggerProvider>; |
There was a problem hiding this comment.
created a new key for the experimental logs, to be confirmed
There was a problem hiding this comment.
to make a comment in the code as well
Karlie-777
commented
Nov 5, 2024
| @@ -53,4 +53,23 @@ export class Logger implements logsAPI.Logger { | |||
| */ | |||
| logRecordInstance._makeReadonly(); | |||
| } | |||
|
|
|||
| // public emitEvent(eventRecord: logsAPI.EventRecord): void { | |||
There was a problem hiding this comment.
Should we have an experimental entry for sdk-logs as well?
Karlie-777
commented
Nov 15, 2024
| version?: string, | ||
| options?: LoggerOptions | ||
| ): Logger | undefined; | ||
| } |
There was a problem hiding this comment.
maybe add a baseLogger as well?
Karlie-777
commented
Nov 15, 2024
| * @param logRecord | ||
| */ | ||
| emitEvent(eventRecord: EventRecord): void { | ||
| this._getLogger().emitEvent(eventRecord); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Draft] Add
emitEventto Logs APITODO: Bridge current events API
emitto logs APIemitEventfor backward compatibility.