chore: add workflow to format using prettier #2545
Conversation
|
Converted PR to draft as the formatting changes still need to be added before it can be merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2545 +/- ##
=======================================
Coverage 90.75% 90.75%
=======================================
Files 169 169
Lines 8018 8018
Branches 1632 1632
=======================================
Hits 7277 7277
Misses 741 741
|
|
The "Format" workflow failed as expected Run npm run format
> [email protected] format
> prettier --check $(git ls-files '*.ts')
Checking formatting...
[warn] examples/express/src/client.ts
[warn] examples/express/src/server.ts
[warn] examples/express/src/tracer.ts
[warn] examples/koa/src/client.ts
[warn] examples/koa/src/server.ts
[warn] examples/koa/src/tracer.ts
[warn] examples/mongodb/src/client.ts
[warn] examples/mongodb/src/server.ts
[warn] examples/mongodb/src/tracer.ts
[warn] examples/mongodb/src/utils.ts
[warn] examples/mysql/src/client.ts
[warn] examples/mysql/src/server.ts
[warn] examples/mysql/src/tracer.ts
[warn] examples/redis/src/client.ts
[warn] examples/redis/src/express-tracer-handlers.ts
[warn] examples/redis/src/server.ts
[warn] examples/redis/src/setup-redis.ts
[warn] examples/redis/src/tracer.ts
[warn] Code style issues found in 1[8](https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/11958404330/job/33337854936?pr=2545#step:5:9) files. Forgot to run Prettier?
Error: Process completed with exit code 1. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Math.random().toString(36).substring(2, 15) + | ||
| Math.random().toString(36).substring(2, 15); |
Check failure
Code scanning / CodeQL
Insecure randomness High
There was a problem hiding this comment.
Fix posted in #2546, as it's not related to formatting
|
Formatting was fixed in The "Format" CI is now successful. |
|
The CodeQL error workflow was not there when the last time page was edited in #1938. The error is also in an example code. It shouldn't be blocking this PR which just formats the code. |
|
Marking as draft as CodeQL CI failure unrelated to formatting is fixed in #2546 This PR can be made ready once the fix is merged, and rebased. |
Which problem is this PR solving?
Short description of the changes
formatcommand and run it in the workflow. Once an existing maintainer approves it, the CI will fail.