chore: remove lerna #2526
chore: remove lerna #2526
Conversation
github-actions
bot
added
pkg:instrumentation-ioredis
pkg:instrumentation-graphql
labels
github-actions
bot
added
pkg:sampler-aws-xray
pkg:resource-detector-container
pkg:resource-detector-azure
pkg:test-utils
pkg:redis-common
pkg:sql-common
pkg:instrumentation-runtime-node
pkg:instrumentation-undici
pkg-status:unmaintained
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2526 +/- ##
==========================================
- Coverage 90.80% 90.75% -0.05%
==========================================
Files 169 169
Lines 8018 8018
Branches 1632 1632
==========================================
- Hits 7281 7277 -4
- Misses 737 741 +4
|
| @@ -18,17 +18,22 @@ | |||
| "^compile" | |||
| ], | |||
| "inputs": [ | |||
| "{projectRoot}/src", | |||
| "{projectRoot}/test" | |||
| "{projectRoot}/src/**/*.ts", | |||
There was a problem hiding this comment.
note to reviewer: although nx documentation says using folder names is okay I found this option to be more sensitive to changes.
| @@ -19,4 +19,4 @@ jobs: | |||
| run: npm ci | |||
|
|
|||
| - name: Check API dependency semantics | |||
| run: npx lerna exec "node \$LERNA_ROOT_PATH/scripts/peer-api-check.js" | |||
| run: node ./scripts/peer-api-check.js | |||
There was a problem hiding this comment.
note for reviewer: this script was used only here so now it's changed to walk over all packages to do the API check.
| - name: Install lerna | ||
| run: npm install -g [email protected] | ||
| - name: Install glob | ||
| run: npm install glob |
There was a problem hiding this comment.
note for reviewer: necessary dependency for the next step
| @@ -90,19 +90,14 @@ Create a pull request titled `chore: x.y.z release proposal`. The commit body sh | |||
|
|
|||
| Merge the PR, and pull the changes locally (using the commands in the first step). Ensure that `chore: x.y.z release proposal` is the most recent commit. | |||
|
|
|||
| ## Publish all packages | |||
| ## Compile all packages | |||
There was a problem hiding this comment.
note to reviewer: IMO this step was missing since npm publish will pack and publish the packages in whatever state it is. With a full compilation everything should be in the right state for publishing
There was a problem hiding this comment.
note to self: although manual release is unlikely to happen we should provide a way to do it. So we need to provide an alternative to the command lerna publish --skip-npm --no-git-tag-version --no-push
Do not merge this PR until this is resolved.
There was a problem hiding this comment.
This is now implemented in ./scripts/bump-package-versions.mjs
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
Which problem is this PR solving?
This is a follow up PR of #2493. It removes
lernaas a dependency and also from the CI workflows. All scripts andlernacommands have been replaced by its equivalent innx(lerna was using them internally) or custom scripts.Changes
lernadependencyscripts/peer-api-check.mjsto work at the root level and the dependant workflowspublish-to-npm.mjsscript and update the release workflowfocusnpm script for people who does not want to compile all project to start developingscripts/bump-package-versions.mjsto help with manual releases