-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate rxjava3 unit tests to Java #7924
Merged
mateuszrzeszutek
merged 5 commits into
open-telemetry:main
from
kaibocai7:rxjava-unit-test
Apr 21, 2023
Merged
Migrate rxjava3 unit tests to Java #7924
mateuszrzeszutek
merged 5 commits into
open-telemetry:main
from
kaibocai7:rxjava-unit-test
Apr 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kaibocai7
commented
Feb 28, 2023
...ing/src/main/java/io/opentelemetry/instrumentation/rxjava/v3/common/AbstractRxJava3Test.java
Show resolved
Hide resolved
kaibocai7
force-pushed
the
rxjava-unit-test
branch
from
March 5, 2023 17:51
c8edf4d
to
6e310be
Compare
For the failed CI |
update testing logics for rxjava update test instance level migrate rxjava3 unit tests to java sort traces for test - format code style migrate rest of tests for rxjava3 format code style
kaibocai7
force-pushed
the
rxjava-unit-test
branch
from
March 11, 2023 14:25
6e310be
to
e84d780
Compare
.../testing/src/main/java/io/opentelemetry/instrumentation/reactor/AbstractReactorCoreTest.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/io/opentelemetry/instrumentation/rxjava/v3/common/AbstractRxJava3Test.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/instrumentation/rxjava/v3/common/AbstractRxJava3SubscriptionTest.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/io/opentelemetry/instrumentation/rxjava/v3/common/AbstractRxJava3Test.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/io/opentelemetry/instrumentation/rxjava/v3/common/AbstractRxJava3Test.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/io/opentelemetry/instrumentation/rxjava/v3/common/AbstractRxJava3Test.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/io/opentelemetry/instrumentation/rxjava/v3/common/AbstractRxJava3Test.java
Show resolved
Hide resolved
...ing/src/main/java/io/opentelemetry/instrumentation/rxjava/v3/common/AbstractRxJava3Test.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/io/opentelemetry/instrumentation/rxjava/v3/common/AbstractRxJava3Test.java
Outdated
Show resolved
Hide resolved
...main/java/io/opentelemetry/instrumentation/rxjava/v3/common/AbstractRxJava3WithSpanTest.java
Outdated
Show resolved
Hide resolved
...ation/rxjava/rxjava-3-common/library/src/test/java/RxJava3AsyncOperationEndStrategyTest.java
Show resolved
Hide resolved
...ation/rxjava/rxjava-3-common/library/src/test/java/RxJava3AsyncOperationEndStrategyTest.java
Outdated
Show resolved
Hide resolved
laurit
approved these changes
Apr 21, 2023
mateuszrzeszutek
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kaibocai7 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate rxjava3 unit tests from groovy to Java. #7195