Convert aws sdk tests for before 1.11.106 from groovy to java #12755
Conversation
jaydeluca
force-pushed
the
convert-aws-1.11-before-1-11
branch
from
4509288
to
0eae90c
Compare
| @RegisterExtension | ||
| private static final InstrumentationExtension testing = AgentInstrumentationExtension.create(); | ||
|
|
||
| private static final AWSCredentialsProviderChain credentialsProvider = |
There was a problem hiding this comment.
Use upper case here and keep same with groovy version? https://google.github.io/styleguide/javaguide.html#s5.2.4-constant-names
There was a problem hiding this comment.
quoting from google style guide linked by @steverao
Constants are static final fields whose contents are deeply immutable and whose methods have no detectable side effects. Examples include primitives, strings, immutable value classes, and anything set to null. If any of the instance's observable state can change, it is not a constant.
according of the above google style guide does not consider this field to be a constant
There was a problem hiding this comment.
Thanks for the reminder from @laurit. After careful consideration, it is reasonable not to set it as a constant. Since it is modified, I think it is OK to use constant like now or keep it as it is.
There was a problem hiding this comment.
@jaydeluca I'd suggest sticking with lowercase, I think we've used the language @laurit cited above previously
| } | ||
|
|
||
| @Test | ||
| void testNaughtyRequestHandlerDoesntBreakTheTrace() { |
Related to #7195