Convert rediscala test to scala #12616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
reviewed
Nov 12, 2024
...rc/test/scala/io/opentelemetry/javaagent/instrumentation/rediscala/RediscalaClientTest.scala
Outdated
Show resolved
Hide resolved
jaydeluca
approved these changes
Nov 12, 2024
steverao
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
BTW, if you can modify the hyperlink to #12553 (comment) in PR description, it will be better for others to understand the background.
|
good idea, I think we've discussed this way back that it's nice to write tests in the language of the library (e.g. kotlin) |
I see |
akats7
pushed a commit
to akats7/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 21, 2024
akats7
pushed a commit
to akats7/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7195
Alternative to #12553