Convert restlet-2.0 tests to java #12348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
force-pushed
the
restlet2-java
branch
from
3c0b867
to
bb34cd6
Compare
jeanbisutti
reviewed
Sep 27, 2024
.../testing/src/main/java/io/opentelemetry/instrumentation/restlet/v2_0/RestletAppTestBase.java
Outdated
Show resolved
Hide resolved
steverao
reviewed
Sep 27, 2024
...g/src/main/java/io/opentelemetry/instrumentation/restlet/v2_0/AbstractRestletServerTest.java
Outdated
Show resolved
Hide resolved
jaydeluca
approved these changes
Sep 29, 2024
| routeClass.getConstructor(Router.class, String.class, Restlet.class); | ||
| Method getTemplate = routeClass.getMethod("getTemplate"); | ||
|
|
||
| List<org.restlet.routing.Route> routes = new ArrayList<>(); |
There was a problem hiding this comment.
is there a reason we are using the FQCN for org.restlet.routing.Route instead of an import? Is it to disambiguate between io.opentelemetry.testing.internal.armeria.server.Route?
There was a problem hiding this comment.
org.restlet.routing.Route is a deprecated class, using it will create a warning. Our build treats warnings as compile errors. To suppress the warning we use @SuppressWarnings("deprecation") but you can't use it on an import so for deprecated classes we need to use FQN.
There was a problem hiding this comment.
thank you for the explanation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #7195