add option to reuse previously auto-generated cert #936

tomplus · 2023-10-29T21:18:48Z

Add a new value autoGenerateCertIfNotExists to control whether certs has to be regenerated on each run or not.

It fixes #845

Thanks!

povilasv · 2023-10-30T08:25:57Z

@tomplus please bump the Chart version and regenerate examples:

make generate-examples CHARTS=opentelemetry-operator

TylerHelmuth · 2023-10-31T02:32:30Z

/cc @JaredTan95

charts/opentelemetry-operator/values.yaml

charts/opentelemetry-operator/templates/admission-webhooks/operator-webhook.yaml

charts/opentelemetry-operator/values.yaml

JaredTan95

LGTM

jinja2 · 2023-11-03T01:52:18Z

charts/opentelemetry-operator/templates/_helpers.tpl

+{{- $caCertEnc = b64enc $ca.Cert }}
+{{- end }}
+{{- else }}
+{{- $certCrtEnc = b64enc .Values.admissionWebhooks.cert_file }}


Not directly related to this PR, since this variable/logic is not newly introduced. Is the variable cert_file meant to be the file path to cert? If that's the intention, we should be using Files.Get to read the content. Same for the key/ca_file vars. We can fix this in a different issue.

Yes, I've noticed it too. In values.yaml there are comments that it's a path but it's treated as data.

Allex1

lgtm
Not sure why Unable to validate cosign version: 'v2.0.0' started failing but seems unrelated to this pr.
@TylerHelmuth can you pls have a look ?

TylerHelmuth · 2023-11-03T16:39:52Z

@tomplus I merged another Operator PR that also fixes the CI issue. Please rebase and regenerate the examples. Thanks for contributing!

tomplus · 2023-11-03T21:31:00Z

It's rebased.
Thanks to all for reviewing.

charts/opentelemetry-operator/values.yaml

charts/opentelemetry-operator/values.schema.json

charts/opentelemetry-operator/UPGRADING.md

Allex1 · 2023-11-15T19:30:44Z

Hi @TylerHelmuth @JaredTan95 can we merge this ? Is it something else that needs adressing?

JaredTan95 · 2023-11-16T00:49:46Z

Hi @TylerHelmuth @JaredTan95 can we merge this ? Is it something else that needs adressing?

I think we can get it in.

JaredTan95 · 2023-11-16T03:32:53Z

@tomplus pls resolve conflicts~

tomplus · 2023-11-16T20:41:39Z

@JaredTan95 rebased, version updated

TylerHelmuth

Our CI isn't able to test this new change because it always gets a fresh env. Can you provide some test results from you local tests of this feature?

charts/opentelemetry-operator/_helpers.tpl

tomplus · 2023-11-16T21:31:13Z

my test:

install chart from my local directory:

helm install test-otel-op . -ntest3 --set admissionWebhooks.certManager.enabled=False

inspect created ca/key/cert (jq to get keys from secret to calc md5 sum)

kubectl get secret test-otel-op-opentelemetry-operator-controller-manager-service-cert -n test3 -ojson | jq '.data' | md5sum
b6f72381930de584378baf32ec1c3ab1  -

update chart

helm upgrade test-otel-op . -ntest3 --reuse-values

verify ca/key/cert - should be different

kubectl get secret test-otel-op-opentelemetry-operator-controller-manager-service-cert -n test3 -ojson | jq '.data' | md5sum
0d1225664c7691e59c157b9c38232ae5  -

upgrade again with option recreate=False

helm upgrade test-otel-op . -ntest3 --reuse-values --set admissionWebhooks.autoGenerateCert.recreate=False

verify certs, should be unchanged (the same checksum)

kubectl get secret test-otel-op-opentelemetry-operator-controller-manager-service-cert -n test3 -ojson | jq '.data' | md5sum
0d1225664c7691e59c157b9c38232ae5  -

and recreate=True again

helm upgrade test-otel-op . -ntest3 --reuse-values --set admissionWebhooks.autoGenerateCert.recreate=True

and I get new ca/cert/key

kubect get secret test-otel-op-opentelemetry-operator-controller-manager-service-cert -n test3 -ojson | jq '.data' | md5sum
95cd92880d3dc38ea6565cf1134c319e  -

* Bump collector version to 0.80.0 (open-telemetry#815) * [opentelemetry-collector] recombine cri multi-line logs (open-telemetry#818) * [demo] Bump OTel Collector chart version (open-telemetry#821) See: open-telemetry#817 (comment) Signed-off-by: Goutham <[email protected]> * Feat/extra env from (open-telemetry#820) * feat(collector-chart): add extraEnvFrom support * chore(examples): adding examples * bump operator (open-telemetry#823) * bump collector (open-telemetry#830) * JAC: fix checksum config in statefulset template (open-telemetry#827) * Adds short usage instructions to UPGRADING.md (open-telemetry#826) * Adds short usage instructions to UPGRADING.md * Updated chart version and regenerated examples * Bump operator (open-telemetry#832) * Fix typo in README.md (open-telemetry#831) * Add new helm command to README.md, fix typos (open-telemetry#836) * Add new helm command to README.md, fix typos + Add link to logging exporter * bump operator chart version * Revert "bump operator chart version" This reverts commit 91430ff. * bump operator patch version * Add externalTrafficPolicy value for service type LoadBalancer (open-telemetry#838) Signed-off-by: Alban HURTAUD <[email protected]> * [collector] Respect pipeline order when enabling kubernetesAttributes (open-telemetry#844) * fix pipeline order when enabling k8sattributes * bump collector and document breakage * kubernetesAttributes example * regenerate examples * Update charts/opentelemetry-collector/UPGRADING.md Co-authored-by: Tyler Helmuth <[email protected]> --------- Co-authored-by: Tyler Helmuth <[email protected]> * [collector] Allow disabling service even for deployment and statefulset (open-telemetry#843) * Allow disabling all ports * temp * generate examples * Bump version * bump collector to 0.82.0 (open-telemetry#847) * charts/opentelemetry-collector: recommended CPU limit pushes just over threshold (open-telemetry#851) * charts/opentelemetry-collector: fix CPU limit While "256m" is a valid setting, the intention was likely to allow 4 pods to be scheduled on a single CPU, which we will currently overshoot by 24/1000, since there are only 1000 units in a CPU fraction. Adjust to "250m", which would allow exactly 4 pods to share a CPU. See e.g. https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-cpu * Update charts/opentelemetry-collector/values.yaml Co-authored-by: Tyler Helmuth <[email protected]> --------- Co-authored-by: Tyler Helmuth <[email protected]> * Upgrade operator to v0.82.0 (open-telemetry#854) * Upgrade operator to v0.82.0 * ci: fix operator E2E tests * [collector] Allow disabling all ports (open-telemetry#842) * Allow disabling all ports * bump patch version instead * chore(demo): update chart dependencies (open-telemetry#856) * update chart dependencies Signed-off-by: Pierre Tessier <[email protected]> * update chart dependencies Signed-off-by: Pierre Tessier <[email protected]> * update chart dependencies Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> * Bump collector version (open-telemetry#861) * Update clusterrole (open-telemetry#860) * mode: daemonset example indicates hostNetwork: true is required (open-telemetry#849) * add more extraction to preset (open-telemetry#867) * bump operator version to 0.83.0 (open-telemetry#874) * [collector] Update readme (open-telemetry#875) * Update readme with all presets * Add generic list reminder * [collector] Update readme and preset comments (open-telemetry#876) * Update readme and preset comments * Add links to docs from values.yaml * Add missed links * [collector] Make it possible to specify namespace when running Helm template (open-telemetry#871) * bump collector to 0.84.0 (open-telemetry#883) * [collector] limit prometheus rules to opentelemetrycollector application (open-telemetry#885) Signed-off-by: Andre Baptista Aguas <[email protected]> * [demo] Use k8sattributesprocessor instead of env vars (open-telemetry#817) * [demo] Use k8sattributesprocessor instead of env vars Signed-off-by: Goutham <[email protected]> * Add 0.24 to upgrading.md Signed-off-by: Goutham <[email protected]> * Update charts/opentelemetry-demo/UPGRADING.md --------- Signed-off-by: Goutham <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> * Bump collector to 0.85.0 (open-telemetry#890) * [operator]: Update UPGRADING.md (open-telemetry#886) (open-telemetry#888) * Bump actions/checkout from 3 to 4 (open-telemetry#884) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [demo] - update for 1.5 release (open-telemetry#873) * update chart dependencies Signed-off-by: Pierre Tessier <[email protected]> * update chart dependencies Signed-off-by: Pierre Tessier <[email protected]> * use frontendProxy for all communication Signed-off-by: Pierre Tessier <[email protected]> * update chart dependencies Signed-off-by: Pierre Tessier <[email protected]> * demo 1.5 release Signed-off-by: Pierre Tessier <[email protected]> * demo 1.5 release Signed-off-by: Pierre Tessier <[email protected]> * demo 1.5 release Signed-off-by: Pierre Tessier <[email protected]> * demo 1.5 release Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> * (demo): update chart dependencies (open-telemetry#893) * update demo chart dependencies Signed-off-by: Pierre Tessier <[email protected]> * update demo chart dependencies Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> * [operator] bump operator to 0.84.0 (open-telemetry#894) * update environment variable reference (open-telemetry#898) * bump operator to 0.85.0 (open-telemetry#896) * Bump collector to 0.86.0 (open-telemetry#897) * update charts to use debug exporter (open-telemetry#892) * update charts to use debug exporter The logging exporter is being deprecated in favour of the debug exporter. This changes the charts to use that exporter instead. Note: this will remain in draft until v0.86.0 is released which will be the first release to include the debug exporter. Signed-off-by: Alex Boten <[email protected]> * make generate-examples CHARTS=opentelemetry-collector Signed-off-by: Alex Boten <[email protected]> * update charts Signed-off-by: Alex Boten <[email protected]> * revert demo charts Signed-off-by: Alex Boten <[email protected]> * bump version for collector/operator charts Signed-off-by: Alex Boten <[email protected]> * patch bump Signed-off-by: Alex Boten <[email protected]> --------- Signed-off-by: Alex Boten <[email protected]> * update prometheus to use otlp write (open-telemetry#901) Signed-off-by: Pierre Tessier <[email protected]> * [demo] Bump collector chart dep (open-telemetry#903) * Bump collector chart * bump version * Switch to tail mode for logsCollection preset (open-telemetry#904) * (demo): update grafana dashboards (open-telemetry#902) * update grafana dashboards Signed-off-by: Pierre Tessier <[email protected]> * update grafana dashboards Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> * [collector] re-add the logging exporter config (open-telemetry#907) * re-add the logging exporter config * Add warning in NOTES.txt * [collector] Remove deprecated fields (open-telemetry#908) * Remove deprecated fields * update resources warning * [collector] Add ability to enable GOMEMLIMIT (open-telemetry#900) * Add ability to enable GOMEMLIMIT * remove trailing spaces * Fix title * Update charts/opentelemetry-collector/UPGRADING.md Co-authored-by: Pablo Baeyens <[email protected]> * Update charts/opentelemetry-collector/UPGRADING.md Co-authored-by: Pablo Baeyens <[email protected]> * update warning * Cleanup merge * Apply suggestions from code review Co-authored-by: Jina Jain <[email protected]> --------- Co-authored-by: Pablo Baeyens <[email protected]> Co-authored-by: Jina Jain <[email protected]> * fix GOMEMLIMIT wrong unit (open-telemetry#913) * [opentelemetry-operator] Add affinity, tolerations and nodeSelector to tests (open-telemetry#911) * Add affinity, tolerations and nodeSelector to tests * Change version from 0.40.0 to 0.39.2 * Generate release notes (open-telemetry#916) * bump collector version to 0.87.0 (open-telemetry#917) * fix prometheus endpoint (open-telemetry#920) Signed-off-by: Pierre Tessier <[email protected]> * [operator] bump to 0.86.0 (open-telemetry#919) * (demo) fix jaeger spm and prometheus config (open-telemetry#922) * fix jaeger spm and prom config Signed-off-by: Pierre Tessier <[email protected]> * fix jaeger spm and prom config Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> * [otel-demo] Include namespace in NOTES.txt (open-telemetry#925) * Include namespace in NOTES.txt For full copy & paste, the port-forwarding instructions need to include the namespace. * Bump version && regenerate examples * [otel-demo] Fix exporter environment variable (open-telemetry#927) * bump operator version (open-telemetry#926) * Bump collector to 0.88.0 (open-telemetry#935) * [collector] Update prometheus alerts (open-telemetry#933) * upgrade to 0.88 include bridge (open-telemetry#938) * upgrade to 0.88 include bridge * facepalm * Fix testing action * version fix * update schema * add rbac for bridges * Rename * install prom CRDs for operator e2e tests * Fix prometheuscr test * [demo] add replicas support (open-telemetry#934) * add replicas support Signed-off-by: Pierre Tessier <[email protected]> * note about replicas setting for postgres, kafka, and redis Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> * [demo] update to demo 1.6 (open-telemetry#942) * update to demo 1.6 Signed-off-by: Pierre Tessier <[email protected]> * update to demo 1.6 Signed-off-by: Pierre Tessier <[email protected]> * update to demo 1.6 Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> * Bump helm/chart-releaser-action from 1.5.0 to 1.6.0 (open-telemetry#944) Bumps [helm/chart-releaser-action](https://github.com/helm/chart-releaser-action) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/helm/chart-releaser-action/releases) - [Commits](helm/chart-releaser-action@v1.5.0...v1.6.0) --- updated-dependencies: - dependency-name: helm/chart-releaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update clusterrole.yaml (open-telemetry#947) * Adding namespace scope to webhook config (open-telemetry#940) * add option to reuse previously auto-generated cert (open-telemetry#936) * add option to reuse previously auto-generated cert * bump chart version * autoGenerateCert as object with enabled, ifNotExists properties * value renamed, ca in secret, logic moved to _helper * fix default value * Update upgrade guidelines * update UPGRADING.md doc * remove unused file * Bump collector version to 0.89.0 (open-telemetry#955) * [CHORE] adding eBPF helm chart (open-telemetry#855) * [CHORE] adding eBPF helm chart Signed-off-by: Nicolas Takashi <[email protected]> * Update .github/workflows/ebpf-test.yaml Co-authored-by: Tyler Helmuth <[email protected]> * Update charts/opentelemetry-ebpf/Chart.yaml Co-authored-by: Tyler Helmuth <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Jared Tan <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Jared Tan <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Jared Tan <[email protected]> * Update README.md Co-authored-by: Jared Tan <[email protected]> * Update README.md Co-authored-by: Jared Tan <[email protected]> * Update README.md Co-authored-by: Jared Tan <[email protected]> * Update charts/opentelemetry-ebpf/CONTRIBUTING.md * Update charts/opentelemetry-ebpf/values.yaml * Update charts/opentelemetry-ebpf/values.yaml Co-authored-by: Dmitrii Anoshin <[email protected]> --------- Signed-off-by: Nicolas Takashi <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> Co-authored-by: Jared Tan <[email protected]> Co-authored-by: Dmitrii Anoshin <[email protected]> * [BUMP] Operator v0.89.0/kube-rbac-proxy v0.15.0 (open-telemetry#963) * [BUMP] Operator v0.89.0/kube-rbac-proxy v0.15.0 * fix * Add JaredTan95 to approvers list (open-telemetry#965) * [collector] fix clusterrolebinding binding wrong namespace (open-telemetry#960) * fix clusterrolebinding binding wrong namespace * remove examples --------- Co-authored-by: Tyler Helmuth <[email protected]> * [collector] support add additionalLabels for otel col resources (open-telemetry#968) * support add additionalLabels for all resources * add comments * Update charts/opentelemetry-collector/values.yaml Co-authored-by: Jina Jain <[email protected]> * add comments * Update charts/opentelemetry-collector/values.yaml Co-authored-by: Tyler Helmuth <[email protected]> --------- Co-authored-by: Jina Jain <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> * Bump collector to 0.90.0 (open-telemetry#972) * Add k8s infra monitorig demo example (open-telemetry#967) * Add k8s infra monitorig demo example Signed-off-by: ChrsMark <[email protected]> * Upgrade chart version Signed-off-by: ChrsMark <[email protected]> * Bump patch version instead of minor Signed-off-by: ChrsMark <[email protected]> --------- Signed-off-by: ChrsMark <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> * Bump collector to 0.90.1 (open-telemetry#975) * Make the service port for the webhook configurable (open-telemetry#976) * make the service port for the webhook configurable * service port * version bump * version bump the examples * enable useGOMEMLIMIT by default (open-telemetry#977) * Bump operator to 0.90.0 (open-telemetry#979) * Bump operator to 0.90.0 * Fix E2E test runner in CI * Bump actions/stale from 8 to 9 (open-telemetry#978) Bumps [actions/stale](https://github.com/actions/stale) from 8 to 9. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v8...v9) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [opentelemetry-collector] update collector to v0.91.0 (open-telemetry#981) --------- Signed-off-by: Goutham <[email protected]> Signed-off-by: Alban HURTAUD <[email protected]> Signed-off-by: Pierre Tessier <[email protected]> Signed-off-by: Andre Baptista Aguas <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Alex Boten <[email protected]> Signed-off-by: Nicolas Takashi <[email protected]> Signed-off-by: ChrsMark <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> Co-authored-by: Goutham Veeramachaneni <[email protected]> Co-authored-by: PaoloGallina <[email protected]> Co-authored-by: Jorge Andreu Calatayud <[email protected]> Co-authored-by: Peter Kern <[email protected]> Co-authored-by: Jan Katins <[email protected]> Co-authored-by: Marcin Ziółkowski <[email protected]> Co-authored-by: Alban Hurtaud <[email protected]> Co-authored-by: Jakob Demler <[email protected]> Co-authored-by: Kevin Burke <[email protected]> Co-authored-by: Mikołaj Świątek <[email protected]> Co-authored-by: Pierre Tessier <[email protected]> Co-authored-by: Mitch <[email protected]> Co-authored-by: Krisztian Fekete <[email protected]> Co-authored-by: André Águas <[email protected]> Co-authored-by: Goutham Veeramachaneni <[email protected]> Co-authored-by: galen-reltio <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Boten <[email protected]> Co-authored-by: Pablo Baeyens <[email protected]> Co-authored-by: Jina Jain <[email protected]> Co-authored-by: Jared Tan <[email protected]> Co-authored-by: Julia Jia <[email protected]> Co-authored-by: Marco Aurelio Caldas Miranda <[email protected]> Co-authored-by: Cedric Ziel <[email protected]> Co-authored-by: Alex <[email protected]> Co-authored-by: Jacob Aronoff <[email protected]> Co-authored-by: Abhishek <[email protected]> Co-authored-by: Grétar Hauksson <[email protected]> Co-authored-by: Tomasz Prus <[email protected]> Co-authored-by: Nicolas Takashi <[email protected]> Co-authored-by: Dmitrii Anoshin <[email protected]> Co-authored-by: Chris Mark <[email protected]>

* Bump collector version to 0.80.0 (open-telemetry#815) * [opentelemetry-collector] recombine cri multi-line logs (open-telemetry#818) * [demo] Bump OTel Collector chart version (open-telemetry#821) See: open-telemetry#817 (comment) Signed-off-by: Goutham <[email protected]> * Feat/extra env from (open-telemetry#820) * feat(collector-chart): add extraEnvFrom support * chore(examples): adding examples * bump operator (open-telemetry#823) * bump collector (open-telemetry#830) * JAC: fix checksum config in statefulset template (open-telemetry#827) * Adds short usage instructions to UPGRADING.md (open-telemetry#826) * Adds short usage instructions to UPGRADING.md * Updated chart version and regenerated examples * Bump operator (open-telemetry#832) * Fix typo in README.md (open-telemetry#831) * Add new helm command to README.md, fix typos (open-telemetry#836) * Add new helm command to README.md, fix typos + Add link to logging exporter * bump operator chart version * Revert "bump operator chart version" This reverts commit 91430ff. * bump operator patch version * Add externalTrafficPolicy value for service type LoadBalancer (open-telemetry#838) Signed-off-by: Alban HURTAUD <[email protected]> * [collector] Respect pipeline order when enabling kubernetesAttributes (open-telemetry#844) * fix pipeline order when enabling k8sattributes * bump collector and document breakage * kubernetesAttributes example * regenerate examples * Update charts/opentelemetry-collector/UPGRADING.md Co-authored-by: Tyler Helmuth <[email protected]> --------- Co-authored-by: Tyler Helmuth <[email protected]> * [collector] Allow disabling service even for deployment and statefulset (open-telemetry#843) * Allow disabling all ports * temp * generate examples * Bump version * bump collector to 0.82.0 (open-telemetry#847) * charts/opentelemetry-collector: recommended CPU limit pushes just over threshold (open-telemetry#851) * charts/opentelemetry-collector: fix CPU limit While "256m" is a valid setting, the intention was likely to allow 4 pods to be scheduled on a single CPU, which we will currently overshoot by 24/1000, since there are only 1000 units in a CPU fraction. Adjust to "250m", which would allow exactly 4 pods to share a CPU. See e.g. https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-cpu * Update charts/opentelemetry-collector/values.yaml Co-authored-by: Tyler Helmuth <[email protected]> --------- Co-authored-by: Tyler Helmuth <[email protected]> * Upgrade operator to v0.82.0 (open-telemetry#854) * Upgrade operator to v0.82.0 * ci: fix operator E2E tests * [collector] Allow disabling all ports (open-telemetry#842) * Allow disabling all ports * bump patch version instead * chore(demo): update chart dependencies (open-telemetry#856) * update chart dependencies Signed-off-by: Pierre Tessier <[email protected]> * update chart dependencies Signed-off-by: Pierre Tessier <[email protected]> * update chart dependencies Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> * Bump collector version (open-telemetry#861) * Update clusterrole (open-telemetry#860) * mode: daemonset example indicates hostNetwork: true is required (open-telemetry#849) * add more extraction to preset (open-telemetry#867) * bump operator version to 0.83.0 (open-telemetry#874) * [collector] Update readme (open-telemetry#875) * Update readme with all presets * Add generic list reminder * [collector] Update readme and preset comments (open-telemetry#876) * Update readme and preset comments * Add links to docs from values.yaml * Add missed links * [collector] Make it possible to specify namespace when running Helm template (open-telemetry#871) * bump collector to 0.84.0 (open-telemetry#883) * [collector] limit prometheus rules to opentelemetrycollector application (open-telemetry#885) Signed-off-by: Andre Baptista Aguas <[email protected]> * [demo] Use k8sattributesprocessor instead of env vars (open-telemetry#817) * [demo] Use k8sattributesprocessor instead of env vars Signed-off-by: Goutham <[email protected]> * Add 0.24 to upgrading.md Signed-off-by: Goutham <[email protected]> * Update charts/opentelemetry-demo/UPGRADING.md --------- Signed-off-by: Goutham <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> * Bump collector to 0.85.0 (open-telemetry#890) * [operator]: Update UPGRADING.md (open-telemetry#886) (open-telemetry#888) * Bump actions/checkout from 3 to 4 (open-telemetry#884) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [demo] - update for 1.5 release (open-telemetry#873) * update chart dependencies Signed-off-by: Pierre Tessier <[email protected]> * update chart dependencies Signed-off-by: Pierre Tessier <[email protected]> * use frontendProxy for all communication Signed-off-by: Pierre Tessier <[email protected]> * update chart dependencies Signed-off-by: Pierre Tessier <[email protected]> * demo 1.5 release Signed-off-by: Pierre Tessier <[email protected]> * demo 1.5 release Signed-off-by: Pierre Tessier <[email protected]> * demo 1.5 release Signed-off-by: Pierre Tessier <[email protected]> * demo 1.5 release Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> * (demo): update chart dependencies (open-telemetry#893) * update demo chart dependencies Signed-off-by: Pierre Tessier <[email protected]> * update demo chart dependencies Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> * [operator] bump operator to 0.84.0 (open-telemetry#894) * update environment variable reference (open-telemetry#898) * bump operator to 0.85.0 (open-telemetry#896) * Bump collector to 0.86.0 (open-telemetry#897) * update charts to use debug exporter (open-telemetry#892) * update charts to use debug exporter The logging exporter is being deprecated in favour of the debug exporter. This changes the charts to use that exporter instead. Note: this will remain in draft until v0.86.0 is released which will be the first release to include the debug exporter. Signed-off-by: Alex Boten <[email protected]> * make generate-examples CHARTS=opentelemetry-collector Signed-off-by: Alex Boten <[email protected]> * update charts Signed-off-by: Alex Boten <[email protected]> * revert demo charts Signed-off-by: Alex Boten <[email protected]> * bump version for collector/operator charts Signed-off-by: Alex Boten <[email protected]> * patch bump Signed-off-by: Alex Boten <[email protected]> --------- Signed-off-by: Alex Boten <[email protected]> * update prometheus to use otlp write (open-telemetry#901) Signed-off-by: Pierre Tessier <[email protected]> * [demo] Bump collector chart dep (open-telemetry#903) * Bump collector chart * bump version * Switch to tail mode for logsCollection preset (open-telemetry#904) * (demo): update grafana dashboards (open-telemetry#902) * update grafana dashboards Signed-off-by: Pierre Tessier <[email protected]> * update grafana dashboards Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> * [collector] re-add the logging exporter config (open-telemetry#907) * re-add the logging exporter config * Add warning in NOTES.txt * [collector] Remove deprecated fields (open-telemetry#908) * Remove deprecated fields * update resources warning * [collector] Add ability to enable GOMEMLIMIT (open-telemetry#900) * Add ability to enable GOMEMLIMIT * remove trailing spaces * Fix title * Update charts/opentelemetry-collector/UPGRADING.md Co-authored-by: Pablo Baeyens <[email protected]> * Update charts/opentelemetry-collector/UPGRADING.md Co-authored-by: Pablo Baeyens <[email protected]> * update warning * Cleanup merge * Apply suggestions from code review Co-authored-by: Jina Jain <[email protected]> --------- Co-authored-by: Pablo Baeyens <[email protected]> Co-authored-by: Jina Jain <[email protected]> * fix GOMEMLIMIT wrong unit (open-telemetry#913) * [opentelemetry-operator] Add affinity, tolerations and nodeSelector to tests (open-telemetry#911) * Add affinity, tolerations and nodeSelector to tests * Change version from 0.40.0 to 0.39.2 * Generate release notes (open-telemetry#916) * bump collector version to 0.87.0 (open-telemetry#917) * fix prometheus endpoint (open-telemetry#920) Signed-off-by: Pierre Tessier <[email protected]> * [operator] bump to 0.86.0 (open-telemetry#919) * (demo) fix jaeger spm and prometheus config (open-telemetry#922) * fix jaeger spm and prom config Signed-off-by: Pierre Tessier <[email protected]> * fix jaeger spm and prom config Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> * [otel-demo] Include namespace in NOTES.txt (open-telemetry#925) * Include namespace in NOTES.txt For full copy & paste, the port-forwarding instructions need to include the namespace. * Bump version && regenerate examples * [otel-demo] Fix exporter environment variable (open-telemetry#927) * bump operator version (open-telemetry#926) * Bump collector to 0.88.0 (open-telemetry#935) * [collector] Update prometheus alerts (open-telemetry#933) * upgrade to 0.88 include bridge (open-telemetry#938) * upgrade to 0.88 include bridge * facepalm * Fix testing action * version fix * update schema * add rbac for bridges * Rename * install prom CRDs for operator e2e tests * Fix prometheuscr test * [demo] add replicas support (open-telemetry#934) * add replicas support Signed-off-by: Pierre Tessier <[email protected]> * note about replicas setting for postgres, kafka, and redis Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> * [demo] update to demo 1.6 (open-telemetry#942) * update to demo 1.6 Signed-off-by: Pierre Tessier <[email protected]> * update to demo 1.6 Signed-off-by: Pierre Tessier <[email protected]> * update to demo 1.6 Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> * Bump helm/chart-releaser-action from 1.5.0 to 1.6.0 (open-telemetry#944) Bumps [helm/chart-releaser-action](https://github.com/helm/chart-releaser-action) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/helm/chart-releaser-action/releases) - [Commits](helm/chart-releaser-action@v1.5.0...v1.6.0) --- updated-dependencies: - dependency-name: helm/chart-releaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update clusterrole.yaml (open-telemetry#947) * Adding namespace scope to webhook config (open-telemetry#940) * add option to reuse previously auto-generated cert (open-telemetry#936) * add option to reuse previously auto-generated cert * bump chart version * autoGenerateCert as object with enabled, ifNotExists properties * value renamed, ca in secret, logic moved to _helper * fix default value * Update upgrade guidelines * update UPGRADING.md doc * remove unused file * Bump collector version to 0.89.0 (open-telemetry#955) * [CHORE] adding eBPF helm chart (open-telemetry#855) * [CHORE] adding eBPF helm chart Signed-off-by: Nicolas Takashi <[email protected]> * Update .github/workflows/ebpf-test.yaml Co-authored-by: Tyler Helmuth <[email protected]> * Update charts/opentelemetry-ebpf/Chart.yaml Co-authored-by: Tyler Helmuth <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Jared Tan <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Jared Tan <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Jared Tan <[email protected]> * Update README.md Co-authored-by: Jared Tan <[email protected]> * Update README.md Co-authored-by: Jared Tan <[email protected]> * Update README.md Co-authored-by: Jared Tan <[email protected]> * Update charts/opentelemetry-ebpf/CONTRIBUTING.md * Update charts/opentelemetry-ebpf/values.yaml * Update charts/opentelemetry-ebpf/values.yaml Co-authored-by: Dmitrii Anoshin <[email protected]> --------- Signed-off-by: Nicolas Takashi <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> Co-authored-by: Jared Tan <[email protected]> Co-authored-by: Dmitrii Anoshin <[email protected]> * [BUMP] Operator v0.89.0/kube-rbac-proxy v0.15.0 (open-telemetry#963) * [BUMP] Operator v0.89.0/kube-rbac-proxy v0.15.0 * fix * Add JaredTan95 to approvers list (open-telemetry#965) * [collector] fix clusterrolebinding binding wrong namespace (open-telemetry#960) * fix clusterrolebinding binding wrong namespace * remove examples --------- Co-authored-by: Tyler Helmuth <[email protected]> * [collector] support add additionalLabels for otel col resources (open-telemetry#968) * support add additionalLabels for all resources * add comments * Update charts/opentelemetry-collector/values.yaml Co-authored-by: Jina Jain <[email protected]> * add comments * Update charts/opentelemetry-collector/values.yaml Co-authored-by: Tyler Helmuth <[email protected]> --------- Co-authored-by: Jina Jain <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> * Bump collector to 0.90.0 (open-telemetry#972) * Add k8s infra monitorig demo example (open-telemetry#967) * Add k8s infra monitorig demo example Signed-off-by: ChrsMark <[email protected]> * Upgrade chart version Signed-off-by: ChrsMark <[email protected]> * Bump patch version instead of minor Signed-off-by: ChrsMark <[email protected]> --------- Signed-off-by: ChrsMark <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> * Bump collector to 0.90.1 (open-telemetry#975) * Make the service port for the webhook configurable (open-telemetry#976) * make the service port for the webhook configurable * service port * version bump * version bump the examples * enable useGOMEMLIMIT by default (open-telemetry#977) * Bump operator to 0.90.0 (open-telemetry#979) * Bump operator to 0.90.0 * Fix E2E test runner in CI * Bump actions/stale from 8 to 9 (open-telemetry#978) Bumps [actions/stale](https://github.com/actions/stale) from 8 to 9. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v8...v9) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [opentelemetry-collector] update collector to v0.91.0 (open-telemetry#981) * Set Port for the webhook (open-telemetry#982) * Set webhook port correctly * whoops * [opentelemetry-operator] remove default limits for cpu and memory (open-telemetry#970) * [opentelemetry-operator] remove default limits for cpu and memory * adjusted schema and ran make commands * Updated documentation Signed-off-by: Pieter van der Giessen <[email protected]> --------- Signed-off-by: Pieter van der Giessen <[email protected]> * [demo] update to demo release 1.7 (open-telemetry#983) * update to demo 1.7 Signed-off-by: Pierre Tessier <[email protected]> * update to demo 1.7 Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> * polish otel operator WebhookCert logical (open-telemetry#986) * [operator] fix readme (open-telemetry#987) * fix readme * bump chart version * bump collector to 0.92.0 (open-telemetry#991) * [operator] Bump operator version to 0.91.0 (open-telemetry#989) * Bump operator version * update crds * bump collector version (open-telemetry#993) * Use appVersion by default (open-telemetry#994) * fix grafana dashboards (open-telemetry#1000) Signed-off-by: Pierre Tessier <[email protected]> * [collector] Enable `retry_on_failure` for filelog receiver created by logsCollection preset (open-telemetry#999) * enable filelog with retry_on_failure as default config Signed-off-by: Husni Alhamdani <[email protected]> * enable filelog with retry_on_failure as default config Signed-off-by: Husni Alhamdani <[email protected]> --------- Signed-off-by: Husni Alhamdani <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> * demo: add missing namespace on grafana dashboard (open-telemetry#1002) * demo: add missing namespace on grafana dashboard fixes: open-telemetry#1001 Signed-off-by: hsinhoyeh <[email protected]> * add rendered yamls Signed-off-by: hsinhoyeh <[email protected]> --------- Signed-off-by: hsinhoyeh <[email protected]> * [operator] Bump operator version to 0.92.1 (open-telemetry#998) * Bump operator version to 0.92.0 * update cluster role * generate examples * Bump to 0.92.1 * Revert "update cluster role" This reverts commit 7f43569. * regenerate * [collector] Enable HPA when deploy mode is statefulset (open-telemetry#1011) * [collector] Enable HPA when deploy mode is statefulset Signed-off-by: Husni Alhamdani <[email protected]> * [collector] Enable HPA when deploy mode is statefulset Signed-off-by: Husni Alhamdani <[email protected]> * Add test scenario for HPA of deployment and statefulset Signed-off-by: Husni Alhamdani <[email protected]> --------- Signed-off-by: Husni Alhamdani <[email protected]> * [demo] add mountedConfigMaps support (open-telemetry#1007) * add mountedConfigMaps support Signed-off-by: Pierre Tessier <[email protected]> * add mountedConfigMaps support Signed-off-by: Pierre Tessier <[email protected]> * add mountedConfigMaps support Signed-off-by: Pierre Tessier <[email protected]> * add mountedConfigMaps support Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> Co-authored-by: Jared Tan <[email protected]> * explicitly set healthcheck extension endpoint (open-telemetry#1012) * [opentelemetry-collector] Fix calculation for gomemlimit (open-telemetry#1015) * set gomemlimit correctly * minor fixes * update chart version * update var * remove unittest * remove unittest * [collector] bump appVersion to 0.93.0 (open-telemetry#1018) * Allow for secure deployments by default. (open-telemetry#1019) * Allow for secure deployments by default. * Restored data added during testing to original state. * Updated demo chart README.md. * Added additional comments to values.yaml to illustrate how the new feature can be used. * Executed "make generate-examples" and pushing results. * [opentelemetry-collector] fix HPA kind for StatefulSet mode (open-telemetry#1025) * add helper to set kind in HPA * update autoscaling comment in values * bump version * [operator] Bump operator to 0.93.0 (open-telemetry#1027) * bump operator to 0.93.0 * Update collector version --------- Signed-off-by: Goutham <[email protected]> Signed-off-by: Alban HURTAUD <[email protected]> Signed-off-by: Pierre Tessier <[email protected]> Signed-off-by: Andre Baptista Aguas <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Alex Boten <[email protected]> Signed-off-by: Nicolas Takashi <[email protected]> Signed-off-by: ChrsMark <[email protected]> Signed-off-by: Pieter van der Giessen <[email protected]> Signed-off-by: Husni Alhamdani <[email protected]> Signed-off-by: hsinhoyeh <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> Co-authored-by: Goutham Veeramachaneni <[email protected]> Co-authored-by: PaoloGallina <[email protected]> Co-authored-by: Jorge Andreu Calatayud <[email protected]> Co-authored-by: Peter Kern <[email protected]> Co-authored-by: Jan Katins <[email protected]> Co-authored-by: Marcin Ziółkowski <[email protected]> Co-authored-by: Alban Hurtaud <[email protected]> Co-authored-by: Jakob Demler <[email protected]> Co-authored-by: Kevin Burke <[email protected]> Co-authored-by: Mikołaj Świątek <[email protected]> Co-authored-by: Pierre Tessier <[email protected]> Co-authored-by: Mitch <[email protected]> Co-authored-by: Krisztian Fekete <[email protected]> Co-authored-by: André Águas <[email protected]> Co-authored-by: Goutham Veeramachaneni <[email protected]> Co-authored-by: galen-reltio <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Boten <[email protected]> Co-authored-by: Pablo Baeyens <[email protected]> Co-authored-by: Jina Jain <[email protected]> Co-authored-by: Jared Tan <[email protected]> Co-authored-by: Julia Jia <[email protected]> Co-authored-by: Marco Aurelio Caldas Miranda <[email protected]> Co-authored-by: Cedric Ziel <[email protected]> Co-authored-by: Alex <[email protected]> Co-authored-by: Jacob Aronoff <[email protected]> Co-authored-by: Abhishek <[email protected]> Co-authored-by: Grétar Hauksson <[email protected]> Co-authored-by: Tomasz Prus <[email protected]> Co-authored-by: Nicolas Takashi <[email protected]> Co-authored-by: Dmitrii Anoshin <[email protected]> Co-authored-by: Chris Mark <[email protected]> Co-authored-by: Pieter <[email protected]> Co-authored-by: Husni Alhamdani <[email protected]> Co-authored-by: hsinhoyeh <[email protected]> Co-authored-by: Louis Parkin <[email protected]> Co-authored-by: Alexander Lindeskär <[email protected]>

* add option to reuse previously auto-generated cert * bump chart version * autoGenerateCert as object with enabled, ifNotExists properties * value renamed, ca in secret, logic moved to _helper * fix default value * Update upgrade guidelines * update UPGRADING.md doc * remove unused file

tomplus requested a review from Allex1 as a code owner October 29, 2023 21:18

tomplus requested a review from a team October 29, 2023 21:18

JaredTan95 reviewed Oct 31, 2023

View reviewed changes

charts/opentelemetry-operator/values.yaml Outdated Show resolved Hide resolved

tomplus requested a review from JaredTan95 October 31, 2023 23:16

jinja2 reviewed Oct 31, 2023

View reviewed changes

tomplus requested a review from jinja2 November 2, 2023 22:30

JaredTan95 approved these changes Nov 2, 2023

View reviewed changes

jinja2 reviewed Nov 3, 2023

View reviewed changes

jinja2 approved these changes Nov 3, 2023

View reviewed changes

Allex1 approved these changes Nov 3, 2023

View reviewed changes

tomplus force-pushed the feat/webhooks-certs branch from 68f0a44 to 98bbb0b Compare November 3, 2023 21:19

TylerHelmuth reviewed Nov 5, 2023

View reviewed changes

charts/opentelemetry-operator/values.yaml Outdated Show resolved Hide resolved

charts/opentelemetry-operator/values.schema.json Show resolved Hide resolved

JaredTan95 reviewed Nov 8, 2023

View reviewed changes

charts/opentelemetry-operator/UPGRADING.md Show resolved Hide resolved

tomplus added 6 commits November 16, 2023 21:37

add option to reuse previously auto-generated cert

856583f

bump chart version

bd9a1b8

autoGenerateCert as object with enabled, ifNotExists properties

a8d4c93

value renamed, ca in secret, logic moved to _helper

7d4862e

fix default value

14339eb

Update upgrade guidelines

3efd17f

tomplus force-pushed the feat/webhooks-certs branch from 2306e85 to 3efd17f Compare November 16, 2023 20:39

update UPGRADING.md doc

4bd0bb1

TylerHelmuth reviewed Nov 16, 2023

View reviewed changes

charts/opentelemetry-operator/_helpers.tpl Outdated Show resolved Hide resolved

remove unused file

cc38096

TylerHelmuth approved these changes Nov 16, 2023

View reviewed changes

TylerHelmuth merged commit 456375d into open-telemetry:main Nov 16, 2023
3 checks passed

TylerHelmuth mentioned this pull request Nov 29, 2023

[kubernetes] update autoGenerateCert syntax open-telemetry/opentelemetry.io#3619

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add option to reuse previously auto-generated cert #936

add option to reuse previously auto-generated cert #936

tomplus commented Oct 29, 2023

povilasv commented Oct 30, 2023

TylerHelmuth commented Oct 31, 2023

JaredTan95 left a comment

jinja2 Nov 3, 2023 •

edited

Loading

tomplus Nov 3, 2023

Allex1 left a comment

TylerHelmuth commented Nov 3, 2023

tomplus commented Nov 3, 2023

Allex1 commented Nov 15, 2023

JaredTan95 commented Nov 16, 2023

JaredTan95 commented Nov 16, 2023

tomplus commented Nov 16, 2023

TylerHelmuth left a comment

tomplus commented Nov 16, 2023

add option to reuse previously auto-generated cert #936

add option to reuse previously auto-generated cert #936

Conversation

tomplus commented Oct 29, 2023

povilasv commented Oct 30, 2023

TylerHelmuth commented Oct 31, 2023

JaredTan95 left a comment

Choose a reason for hiding this comment

jinja2 Nov 3, 2023 • edited Loading

Choose a reason for hiding this comment

tomplus Nov 3, 2023

Choose a reason for hiding this comment

Allex1 left a comment

Choose a reason for hiding this comment

TylerHelmuth commented Nov 3, 2023

tomplus commented Nov 3, 2023

Allex1 commented Nov 15, 2023

JaredTan95 commented Nov 16, 2023

JaredTan95 commented Nov 16, 2023

tomplus commented Nov 16, 2023

TylerHelmuth left a comment

Choose a reason for hiding this comment

tomplus commented Nov 16, 2023

jinja2 Nov 3, 2023 •

edited

Loading