fix: Configure feature gates appropriately #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
approved these changes
Nov 13, 2024
thefirstofthe300
force-pushed
the
thefirstofthe300/fix-feature-gates-handling
branch
from
52481dd
to
2b709af
Compare
|
@TylerHelmuth Can this be merged now? |
codeboten
pushed a commit
to codeboten/opentelemetry-helm-charts
that referenced
this pull request
Nov 14, 2024
thefirstofthe300
deleted the
thefirstofthe300/fix-feature-gates-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator does not like feature gates being quoted.
Feature gates are also a flag based on presence. If the flag is present, it is understood to be true, absence leaves the default value.