Deploy podmonitor for all modes #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Infogrid-MattBuckland
requested review from
dmitryax,
TylerHelmuth,
povilasv and
a team
as code owners
The committers listed above are authorized under a signed CLA. |
povilasv
approved these changes
Nov 5, 2024
jaronoff97
approved these changes
Nov 5, 2024
codeboten
pushed a commit
to codeboten/opentelemetry-helm-charts
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see no reason to block the podmonitor resource from being created when the deployment mode is not daemonset. Each of the three possible modes all deploy pods, which one may wish to monitor. Personally I'm deploying as a statefulset and I am still interested to have metrics for this.
I have tested my change with all 3 modes and the podmonitor worked fine for each.