[opentelemetry-kube-stack]: Fix missing "release" label to opentelemetry-kube-stack.labels #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
reviewed
Oct 2, 2024
There was a problem hiding this comment.
@davidcaste thanks for this contribution! can you bump the patch version in the Chart.yaml and then rerun the make generate-examples?
davidcaste
force-pushed
the
fix/add_missing_release_label
branch
from
57944ed
to
e2a972f
Compare
jaronoff97
approved these changes
Oct 2, 2024
|
@davidcaste thank you for your contribution! 🙇 |
codeboten
pushed a commit
to codeboten/opentelemetry-helm-charts
that referenced
this pull request
Nov 14, 2024
…try-kube-stack.labels (open-telemetry#1363) * fix: Add missing release label to opentelemetry-kube-stack.labels * [opentelemetry-kube-stack] Bump to v0.2.2 and regenerate examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The labels in some
ServiceMonitorselectors doesn't match the ones in theServiceobjects, specifically the labelreleaseis missing from some of them.This PR attempts to solve the problem described above. I realized the
opentelemetry-kube-stack.labelsvariable used to populate the labels in mostServiceobjects was missing thereleaselabel. So the fix is as easy to add this label to this variable.Thanks!
Fixes #1362