Explicitly embed CRDs for installation ONLY in the OKS #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
reviewed
Jun 5, 2024
There was a problem hiding this comment.
@jaronoff97 don't we need to template the CRDs in the nested chart in order to make the conversion patch work?
|
@TylerHelmuth I probably need to call this out explicitly, but this is for the world where the conversion webhook is fully unnecessary because we will only be applying v1beta1 CRs. We can do this because the chart is also creating the collectors. |
TylerHelmuth
reviewed
Jun 6, 2024
TylerHelmuth
approved these changes
Jun 6, 2024
JaredTan95
approved these changes
Jun 9, 2024
12ushan
pushed a commit
to giffgaff/opentelemetry-helm-charts
that referenced
this pull request
Jul 22, 2024
…y#1214) * Embed crds * bumpy * fix syntax * add a note * more notes * update note --------- Co-authored-by: Jared Tan <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embeds the CRDs for installation for the opentelemetry-kube-stack chart without handling upgrades for now. This brings us to parity with what the kube-prom-stack chart does. This also unblocks #1166. In the future we should investigate the approach @JaredTan95 describes here.