Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adservice add adServiceHighCpu featureflag to flagd files #1125

Conversation

EislM0203
Copy link
Contributor

@EislM0203 EislM0203 commented Apr 8, 2024

Add adServiceHighCpu featureflag to flagd file. See upstream PR here: open-telemetry/opentelemetry-demo#1510

@EislM0203 EislM0203 marked this pull request as ready for review April 8, 2024 13:39
@EislM0203 EislM0203 requested a review from puckpuck as a code owner April 8, 2024 13:39
@EislM0203 EislM0203 requested a review from a team April 8, 2024 13:39
@EislM0203 EislM0203 force-pushed the adservice-add-adServiceHighCpu-featureflag-to-flagd.json branch from 184753c to 63c0077 Compare April 8, 2024 13:45
@TylerHelmuth
Copy link
Member

This PR will need to wait for the demo PR to be merged and released.

@EislM0203 EislM0203 force-pushed the adservice-add-adServiceHighCpu-featureflag-to-flagd.json branch from 52cdde6 to 06e1f6a Compare April 15, 2024 06:32
@TylerHelmuth
Copy link
Member

@EislM0203 please run make generate-examples CHARTS-opentelemetry-demo

@TylerHelmuth TylerHelmuth merged commit 8fbed91 into open-telemetry:main Apr 16, 2024
3 checks passed
@EislM0203 EislM0203 deleted the adservice-add-adServiceHighCpu-featureflag-to-flagd.json branch April 16, 2024 21:05
12ushan pushed a commit to giffgaff/opentelemetry-helm-charts that referenced this pull request Jul 22, 2024
…etry#1125)

* adservice add adServiceHighCpu featureflag to flagd files

* add output of make command

bumped minor version by 2 because it was already bumped to 1 by open-telemetry#1126

* add output of make command

---------

Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants