Update Obans semantic conventions #400
Conversation
joshk
force-pushed
the
update-obans-semantic-conventions
branch
from
9448101
to
f9b2a59
Compare
|
@tsloughter, sorry to ask. Would it be possible to get a review on this PR? |
|
Hi @bryannaegele , sorry to ask, would it be possible to get approval for the CI to run for this PR? |
|
Sure. Approving to run. Just took a brief glance (not a review) and there look to be a number of issues still to address with the spec. Please take a pass through the spec to cover your bases. https://opentelemetry.io/docs/specs/semconv/messaging/messaging-spans/ |
|
Hi @bryannaegele , I've updated the code based on the spec, and adjusted the test suite to match. Could you please approve the CI run once more? |
Span names Exception atom instead of string and Oban Job priority after insert
joshk
force-pushed
the
update-obans-semantic-conventions
branch
from
02bff19
to
2ada0a1
Compare
|
@bryannaegele sorry, is there anything i can do to help this move forward? |
|
Hey @joshk, it can take a couple of weeks for me to have time to review a PR. From another quick glance, it looks like there's still a fair amount that doesn't match the spec. A simple one is the span names. There are also updates since the original implementation around batching, so If you can read through the spec top to bottom and go through the requirements one at a time, that can help move things forward. |
|
Hey @bryannaegele , I'm sorry to ping you, and I appreciate the guidance. Hmmm, I went through the spec and thought I had everything up to date. I'll go through everything again. Could you point me to an example of something I haven't implemented correctly? (It would help me see where I'm not reading the spec, if that makes sense) I'm very happy to contribute further, once I'm getting this right :) |
|
I pointed out span names as one example. My recommendation is open the spec page and view it as a check list going from top to bottom, applying anything that's relevant to how oban works |
This also required the removal of
messaging_destination_kind()as I couldn't find an equivalent inopentelemetry_semantic_conventions~> 1.27