Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to pass repo name to setup #332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yordis
Copy link
Contributor

@yordis yordis commented Jun 14, 2024

No description provided.

Copy link
Contributor

@GregMefford GregMefford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have major concerns about this if we can implement it in a reliable way, but I haven't confirmed yet that the proposed change is robust.

@yordis yordis force-pushed the add-repo-atom-to-ecto branch 2 times, most recently from 67a1888 to 527857d Compare July 29, 2024 17:12
@yordis
Copy link
Contributor Author

yordis commented Jul 29, 2024

Hey team, check the latest changes! I addressed your concerns

Copy link
Contributor

@whatyouhide whatyouhide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple more comments to address before merging 🙃

@yordis yordis force-pushed the add-repo-atom-to-ecto branch 4 times, most recently from 60e837a to dce2d46 Compare July 30, 2024 15:17
@yordis yordis requested a review from whatyouhide July 30, 2024 15:17
@yordis
Copy link
Contributor Author

yordis commented Jul 30, 2024

@whatyouhide, it is ready to go now!

Copy link
Contributor

@whatyouhide whatyouhide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 💯 I will let @tsloughter or @bryannaegele merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants