Finch: Sets the trace status to error on any 5xx response #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
elixir
instrumentation
erlang
utilities
opentelemetry_finch
otel_http
labels
utilities/opentelemetry_instrumentation_http/src/opentelemetry_instrumentation_http.erl
Outdated
Show resolved
Hide resolved
utilities/opentelemetry_instrumentation_http/src/opentelemetry_instrumentation_http.erl
Outdated
Show resolved
Hide resolved
jeffutter
force-pushed
the
finch-set-error-on-500
branch
from
5429a10
to
1b50dcd
Compare
According to the [Semantic Conventions](https://opentelemetry.io/docs/specs/semconv/http/http-spans/#status) any trace for a 5xx response should mark the trace with `status: :error`. Previously they were not marked as error unless the client throws an error without reaching the server (timeout, connection refused, etc.) Also added a helper to `utilities/opentelemetry_instrumentation_http/src` to convert the http status codes to binaries to add as the details on the error trace.
…escription As per conventions: > Don’t set the span status description if the reason can be inferred from > http.response.status_code. So we can skip setting the status reason when it's based on HTTP code
jeffutter
force-pushed
the
finch-set-error-on-500
branch
from
1b50dcd
to
d0e180b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Semantic Conventions any trace for a 5xx response should mark the trace with
status: :error. Previously they were not marked as error unless the client throws an error without reaching the server (timeout, connection refused, etc.)