coredump: no need for full dump with bundled files #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid full process coredumps when the ELF files are bundled. This significantly reduces the size of coredumps from large processes. Add "coredump new -sysroot" option to specify sysroot prefix for finding the files to be bundled. Update instructions accordingly.
christos68k
reviewed
Oct 29, 2024
tools/coredump/new.go
Outdated
| // Restore coredump filter mask upon leaving the function. | ||
| defer func() { | ||
| //nolint:gosec | ||
| err2 := os.WriteFile(coredumpFilterPath, prevMask, 0o644) |
There was a problem hiding this comment.
We should convert prevMask to a hex string and write that to coredump_filter, otherwise we may run into the following (we're writing in octal):
WARN[0000] Failed to restore previous coredump filter: write /proc/367787/coredump_filter: invalid argument
Or just from the shell:
$ cat /proc/367787/coredump_filter
00000033
$ echo 00000033 >/proc/367787/coredump_filter
$ cat /proc/367787/coredump_filter
0000001b
$ echo 0000001b >/proc/367787/coredump_filter
-bash: echo: write error: Invalid argument
There was a problem hiding this comment.
Strange kernel inconsistency. And this is just code I reindented. But added a fix by just prepending a 0x literal in the front.
christos68k
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid full process coredumps when the ELF files are bundled. This significantly reduces the size of coredumps from large processes.
Add "coredump new -sysroot" option to specify sysroot prefix for finding the files to be bundled.
Update instructions accordingly.