Setup collector receiver #160
Conversation
dmathieu
force-pushed
the
collector-receiver
branch
5 times, most recently
from
cd467ae
to
a639d0a
Compare
dmathieu
force-pushed
the
collector-receiver
branch
2 times, most recently
from
ccdac1c
to
00c1c6b
Compare
dmathieu
force-pushed
the
collector-receiver
branch
from
00c1c6b
to
032d279
Compare
Co-authored-by: Tim Rühsen <[email protected]>
dmathieu
force-pushed
the
collector-receiver
branch
from
032d279
to
70647f1
Compare
collector/internal/helpers.go
Outdated
| @@ -0,0 +1,236 @@ | |||
| // Copyright The OpenTelemetry Authors | |||
There was a problem hiding this comment.
Can't we move opentelemetry-ebpf-profiler/helpers.go into its own package that we can import here to avoid duplicating all this code?
collector/internal/config.go
Outdated
| ) | ||
|
|
||
| // Config represents the receiver config settings within the collector's config.yaml | ||
| type Config struct { |
There was a problem hiding this comment.
Maybe for another PR, but it'd be nice if we used a single configuration structure to cover both CLI and collector, that way the validation logic would also be shared.
|
|
||
| // Start starts the receiver. | ||
| func (c *Controller) Start(ctx context.Context, host component.Host) error { | ||
| cfg := c.config |
There was a problem hiding this comment.
Since there's a lot of duplication with startup logic in main here, maybe we should factor out commonalities into a separate package (e.g. agent or controller) that we can reuse here and in main.
There was a problem hiding this comment.
While your point definitely makes sense, this is far from being a trivial change in main.go, as it mixes a lot of things together. So making that refactoring looks like it's going to take several PRs.
While I'm happy to look into that, I wonder if we shouldn't start without this refactoring, so we can move forward with the collector support.
|
Moving this back to draft. I realized this uses the OTLPReporter, which doesn't use the collector's |
This is an extraction from #87, with the intent to clean up and setup only the collector receiver, without an attached collector distribution.