Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Fix build for esp32 #3155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

albkharisov
Copy link

@albkharisov albkharisov commented Nov 20, 2024

Fix for toolchains that alias int32_t to long int. In this way we don't have int in variant of attributes.
If it's defined as strict int32_t, int64_t etc, I think it's better to have strict types everywhere.
ESP-IDF (v5.3.1) toolchain fails to compile as they don't have int in attributes variant list.

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Fix for toolchains that alias int32_t as long int and
in this way confuse all the honest people.
@albkharisov albkharisov requested a review from a team as a code owner November 20, 2024 17:12
Copy link

linux-foundation-easycla bot commented Nov 20, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 48678de
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/673e18727c266a0008b54848

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the workflow to run CI, but blocking the merge.

I would like first to understand the issue in more details,
to decide the best course of action for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants