-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] add a test for ElasticSearchRecordable #3154
base: main
Are you sure you want to change the base?
[TEST] add a test for ElasticSearchRecordable #3154
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3154 +/- ##
==========================================
- Coverage 87.86% 87.84% -0.01%
==========================================
Files 195 195
Lines 6151 6151
==========================================
- Hits 5404 5403 -1
- Misses 747 748 +1
|
Bazel on MacOS and IWYU failed for unrelated to this PR reasons; I cannot restart these jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
Waiting a bit for possible comments, then will merge. |
Changes
This PR adds a test for
opentelemetry::exporter::logs::ElasticSearchRecordable
and updates the (disabled) tests for Elasticsearch Logs Exporter to ensure they compile.The plan is to refactor the ES Recordable to use the ADL Serializer. This will make the code much more readable and maintainable (no need to use
nostd::holds_alternative
orvalue.index()
+nostd::get()
and keep the list of the types up-to-date). That is why we need a test to make sure that the refactoring will not break the things.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes