Add devcontainer #3123
Open
Add devcontainer #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3123 +/- ##
==========================================
+ Coverage 87.12% 87.85% +0.73%
==========================================
Files 200 195 -5
Lines 6109 6138 +29
==========================================
+ Hits 5322 5392 +70
+ Misses 787 746 -41 |
psx95
reviewed
Nov 7, 2024
| Before getting started, ensure you have the following installed: | ||
|
|
||
| * **Docker**: DevContainers require Docker for containerization. | ||
| * **Visual Studio Code (VSCode)** with the **Remote - Containers** extension. |
There was a problem hiding this comment.
Haven't used DevContainers before, but I imagine it would be possible to do this without relying on VS Code ?
Please correct me if I'm wrong, but I imagine we could simply exec into a running docker container as well and run CI tests from there ?
I would prefer if we not put in instructions that are IDE specific.
psx95
reviewed
Nov 7, 2024
| ./ci/do_ci.sh {TARGET}` where the targets are: | ||
| CI tests can be run inside | ||
| [devcontainer](../CONTRIBUTING.md#devcontainer-setup-for-project) | ||
| by invoking the script |
There was a problem hiding this comment.
Could we also add a Dockerfile that creates a container with the current codebase and required dependencies to run the CI tests within that container ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3118 (issue)
Changes
bazelisk-linux-amd64 test --copt=-DENABLE_LOGS_PREVIEW --test_output=errors --cache_test_results=no --copt=-DENABLE_TEST //exporters/otlp/...bash ci/do_ci.sh cmake.exporter.otprotocol.testFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes