[xpdata/entity] Rename methods to use updated entity terminology #14275
+62
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename Entity API methods to align with OpenTelemetry specification terminology for attributes in entity context: - IDAttributes() → IdentifyingAttributes() - DescriptionAttributes() → DescriptiveAttributes() This change applies the "Identifying" and "Descriptive" terms specifically to Attributes (not Entity or Entity Keys), as clarified in open-telemetry/opentelemetry-specification#4700
dmitryax
force-pushed
the
update-entities-doc
branch
from
2806ee2 to
936f73f
Compare
dmitryax
commented
Dec 10, 2025
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: breaking |
Member
Author
There was a problem hiding this comment.
Breaking here is fine because it's in x... module and the API hasn't been used yet
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14275 +/- ##
==========================================
- Coverage 92.17% 92.13% -0.04%
==========================================
Files 668 668
Lines 41492 41492
==========================================
- Hits 38244 38230 -14
- Misses 2215 2224 +9
- Partials 1033 1038 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmathieu
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename Entity API methods to align with OpenTelemetry specification terminology for attributes in entity context:
This change applies the "Identifying" and "Descriptive" terms specifically to Attributes (not Entity or Entity Keys), as clarified in open-telemetry/opentelemetry-specification#4700