[receiver/libhoney] Set scopes more flexibly to avoid losing service.name #42432
+81
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
approved these changes
Sep 2, 2025
TylerHelmuth
added
ready to merge
mterhar
force-pushed
the
libhoney/allow-empty-libraryname
branch
from
e46d4b2 to
640c1b5
Compare
codeboten
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bug happens when a library.name isn't set but service.name is set. This causes the service.name to be dropped since the scope includes both.
This change adds placeholder scopes for each service.name that comes in, in the event that no library.name exists it has a fall-back.
This seems to be triggered by Jaeger traces that are converted into otlp since they do not have instrumentation_scope name or version.