[receiver/oracledb] Add service.instance.id resource attribute to metrics and logs #42421
+149
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d query_sample collection
Oracledbreceiver events
Oracle additional attributes
…nto samples payload
sv-splunk
requested review from
dmitryax,
crobert-1,
atoulme and
a team
as code owners
atoulme
reviewed
Sep 2, 2025
|
|
||
| if err != nil { | ||
| logger.Warn("Failed to compute service.instance.id", zap.Error(err)) | ||
| return "unknown:1521" |
There was a problem hiding this comment.
you can still report the right port here
atoulme
reviewed
Sep 2, 2025
| return "unknown:1521" | ||
| } | ||
|
|
||
| return host + ":" + port |
There was a problem hiding this comment.
should this also have the DB name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
service.instance.idattribute is added into resourceAttributes of metrics and logs to uniquely identifyOracle db hosts. The format of id is
<host>:<port>Link to tracking issue
Fixes #42402
Testing
Unit tests are added/updated
Documentation