[pkg/ottl] add ValueExpression to support extraction of values from the signal context
#36883
+229
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
bacherfl
changed the title
ValueExpression to support extraction of values from the signal context
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
| # Include 'user' if the change is relevant to end users. | ||
| # Include 'api' if there is a change to a library API. | ||
| # Default: '[user]' | ||
| change_logs: [] |
There was a problem hiding this comment.
Suggested change
| change_logs: [] | |
| change_logs: [api] |
Since the target of this feature is component authors, we should mark it as an API change.
| func parseValueExpression(raw string) (*value, error) { | ||
| parsed, err := valueExpressionParser.ParseString("", raw) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("condition has invalid syntax: %w", err) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("condition has invalid syntax: %w", err) | |
| return nil, fmt.Errorf("expression has invalid syntax: %w", err) |
| component: pkg/ottl | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Add value expression parser that enables components using ottl to retrieve values from the context, as well as the result of converter functions |
There was a problem hiding this comment.
Suggested change
| note: Add value expression parser that enables components using ottl to retrieve values from the context, as well as the result of converter functions | |
| note: Add value expression parser that enables components using ottl to retrieve values from the output of an expression |
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |
There was a problem hiding this comment.
Suggested change
| subtext: | |
| subtext: the expression can be either a literal value, a path value within the context, or the result of a converter and/or a mathematical expression. |
I think the doc you wrote for this is perfect for describing what can be used inside the subtext.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
ParseValueExpressionmethod to the OTTL parser which allows users of this package to extract data from the context using OTTLLink to tracking issue
Fixes #35621
Testing
Added unit and e2e tests
Documentation
Added godoc comments for the added methods and types