[vcenterreceiver] TLS settings not honored for initial GetServiceContent call #36482
+61
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmikei
approved these changes
Nov 21, 2024
|
I've tested with a variety of TLS settings (using mitmproxy) and things seem good to me and based off those related issues it does seem like underlying client TLS settings should be set this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
govmomiclient used in the receiver attempts to validate the connection to vcenter before the existing code sets the TLS options (other than insecure) in the client. This is a limitation of thegovmomiwrapper, as discussed on this issue: vmware/govmomi#1200 .Link to tracking issue
Related issue in Grafana Alloy: grafana/alloy#193
Testing
This has not been tested, I would appreciate the assistance of any codeowner that could test.See comments on the PR for test.