feat(ottl): Add a new ottl trim function that trims leading and trailing whitespace from a string #36400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnishtala-sumo
requested review from
TylerHelmuth,
bogdandrutu,
evan-bradley and
a team
as code owners
dmitryax
approved these changes
Nov 16, 2024
|
@rnishtala-sumo can you add to the description the issue this PR closes |
…ing whitespace from a string
rnishtala-sumo
force-pushed
the
ottl-trim-function
branch
from
c73ca02
to
b2c24fd
Compare
rnishtala-sumo
force-pushed
the
ottl-trim-function
branch
from
9c7f12c
to
22bb9aa
Compare
rnishtala-sumo
force-pushed
the
ottl-trim-function
branch
from
22bb9aa
to
d088773
Compare
edmocosta
reviewed
Nov 19, 2024
|
|
||
| ```Trim(target, replacement)``` | ||
|
|
||
| The `Trim` Converter removes the leading and trailing character (default: whitespace). |
There was a problem hiding this comment.
I'd also add the default value description on the replacement argument docs
There was a problem hiding this comment.
Yes. Take a look in this README how other Optional parameters are indicated (can use flatten as an example).
|
|
||
| ```Trim(target, replacement)``` | ||
|
|
||
| The `Trim` Converter removes the leading and trailing character (default: whitespace). |
There was a problem hiding this comment.
Yes. Take a look in this README how other Optional parameters are indicated (can use flatten as an example).
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if replacement.IsEmpty() || replacementString == "" { |
There was a problem hiding this comment.
Above line 34, lets to a check for if replacement == "" and error if it is. Calling Trim(name, "") implies a nop, but we'd be trimming " ".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A field test exists in an event, which contains the string " this is a test ".
I would like to be able to transform this using an ottl function trim, that I would define as trim(attribute["test"]), which would trim this down to "this is a test".
this is a testLink to the issue - #34100