Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixing - feedback - Default view for Stars and Forks graph should be time-series #3991

Closed
wants to merge 1 commit into from

Conversation

SURAJ-SHARMA27
Copy link
Contributor

Description

Fixes #3862
I have replaced the previous bar charts with area charts in the star graphs. I have submitted this as a draft PR. If it works well, I will implement this change throughout.

Related Tickets & Documents

Fixes #3862

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit bb26f0f
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66c41c2f94007700087e2197
😎 Deploy Preview https://deploy-preview-3991--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit bb26f0f
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66c41c2f8d76a70008db6550
😎 Deploy Preview https://deploy-preview-3991--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SURAJ-SHARMA27
Copy link
Contributor Author

Should I proceed with creating an area graph under the time series for each plot on the repo page (Stars and forks)? @jpmcb @BekahHW

@jpmcb
Copy link
Member

jpmcb commented Aug 22, 2024

cc @isabensusan - any thoughts on the design here?

@BekahHW BekahHW requested a review from a team August 27, 2024 18:15
@SURAJ-SHARMA27
Copy link
Contributor Author

Hey everyone,

Should I proceed with the proposed idea?

@brandonroberts
Copy link
Contributor

@SURAJ-SHARMA27 I believe the original issue to be resolved was just changing the default. We can revisit changing the style of the chart separately.

@isabensusan
Copy link
Member

@SURAJ-SHARMA27 thanks for your contribution! But like @brandonroberts mentioned, if you take a close look at the original issue #3862 the goal was to just change the default view for the stars and forks charts from Daily to History.

We are not currently looking to update the design of these charts, so I'll be closing this PR, but if you want to tackle changing the default view in a different PR you are welcome to do so!

@SURAJ-SHARMA27
Copy link
Contributor Author

Okay, I understand. Should I just convert the stars and forks graph into a time-series graph as mentioned in the original issue?

@nickytonline
Copy link
Member

I'm not sure where we landed on this @open-sauced/design @open-sauced/engineering.

@nickytonline
Copy link
Member

I'm going to go ahead and close this for now. Feel free to reopen it if you want to continue working on this @SURAJ-SHARMA27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: feedback - Default view for Stars and Forks graph should be time-series
5 participants