Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish updating the implementation of simple_api_server #124

Open
mxgrey opened this issue Feb 13, 2022 · 5 comments
Open

Finish updating the implementation of simple_api_server #124

mxgrey opened this issue Feb 13, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@mxgrey
Copy link
Collaborator

mxgrey commented Feb 13, 2022

As mentioned in this review there appear to be some updates still needed for the simple_api_server.

@mxgrey mxgrey added the bug Something isn't working label Feb 13, 2022
@cnboonhan
Copy link
Contributor

cnboonhan commented Feb 15, 2022

debug.mp4

I can't seem to replicate the issue on a fresh build off main ( the above video is a successful run ), is it possible there is some sort of build issue?

@mxgrey
Copy link
Collaborator Author

mxgrey commented Feb 15, 2022

It's certainly possible that I have some build issue on my end. One difference when I tested was that I submitted the request through the command line, not through the UI, although I can't think of any reason that would matter.

@cnboonhan
Copy link
Contributor

cnboonhan commented Feb 15, 2022

just tried with command line as well, it has the same working behavior as in the video 👍 perhaps you could try a clean build first, and if it doesn't automatically resolve, then it would seem to narrow to a dependency issue, probably from the networking libraries that we may be using different versions of.

The most immediate issue i can find online is this: https://stackoverflow.com/questions/22412873/attributeerror-response-object-has-no-attribute-json

My current version is:

>>> requests.__version__
'2.27.1'
>>>

@mxgrey
Copy link
Collaborator Author

mxgrey commented Feb 15, 2022

Mine came up as 2.26.0. The feature is supposed to be present in that, but the difference in our versions could still indicate that something about my configuration is wonky.

@cnboonhan
Copy link
Contributor

that's very odd. although i don't think we control the version of requests in our installation of rmf_demos, it is probably installed as a dependencies of the other libraries we use, or from a prior installation that already existed on the host.

The pipenv environment that is used in rmf-web can help with such issues, i think the web components of rmf_demos rely on a system installation of dependencies which can get a bit hairy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants